Page MenuHomePhabricator

Get mcrouter & prometheus-mcrouter-exporter tags for helmfile.d from upstream config
Closed, ResolvedPublic

Description

The Toolhub chart includes mcrouter config adapted from work that @Joe did for the mediawiki chart. Part of this config is setting the tag version for the mcrouter and prometheus-mcrouter-exporter images used as sidecar containers.

Currently the helmfile.d settings for Toolhub contain explicit tags, but it would be more ideal for these to be shared configuration maintained for everyone in an /etc/helmfile-defaults file. This would follow the pattern already used for envoy sidecars.

One thing to work out would be the actual setting names. The Toolhub chart and the MediaWiki chart differ slightly in what values.yaml keys are expected to provide the values. The MediaWiki chart expects mw.mcrouter.{image_tag,exporter_version}. The Toolhub chart expects mcrouter.{image_tag,exporter_version} (no mw parent).

Event Timeline

Change 722833 had a related patch set uploaded (by BryanDavis; author: Giuseppe Lavagetto):

[operations/puppet@production] kubernetes::deployment_server: add general data for mcrouter + nutcracker

https://gerrit.wikimedia.org/r/722833

Change 723618 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Get mcrouter image tags from upstream config

https://gerrit.wikimedia.org/r/723618

Change 722833 merged by Giuseppe Lavagetto:

[operations/puppet@production] kubernetes::deployment_server: add general data for mcrouter + nutcracker

https://gerrit.wikimedia.org/r/722833

Change 730557 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/deployment-charts@master] mediawiki: introduce the common_images data structure

https://gerrit.wikimedia.org/r/730557

Change 730558 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/deployment-charts@master] toolhub: use the common_images data structure

https://gerrit.wikimedia.org/r/730558

Change 730559 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/deployment-charts@master] changeprop/api-gateway: use the common_images data structure

https://gerrit.wikimedia.org/r/730559

Change 730558 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: use the common_images data structure

https://gerrit.wikimedia.org/r/730558

Change 723618 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Get mcrouter image tags from upstream config

https://gerrit.wikimedia.org/r/723618

bd808 changed the task status from Open to In Progress.Oct 13 2021, 9:17 PM
bd808 assigned this task to Joe.
bd808 triaged this task as Medium priority.
bd808 moved this task from Review to Radar on the Toolhub board.

The Toolhub specific bits of this are done thanks @Joe. I'm assigning to him so he can close it when he's ready.

Change 730557 merged by Giuseppe Lavagetto:

[operations/deployment-charts@master] mediawiki: introduce the common_images data structure

https://gerrit.wikimedia.org/r/730557

Change 730559 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop/api-gateway: use the common_images data structure

https://gerrit.wikimedia.org/r/730559

This task is resolved. I think it's time we write a style guide to writing a helm chart and managing this kind of stuff.