Page MenuHomePhabricator

[SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H]
Closed, ResolvedPublicSpike

Description

We need to make sure that the IPInfo-related user properties (currently, only "ipinfo-enable") isn't replicated to:

Event Timeline

phuedx renamed this task from Check that IPInfo-related user properties aren't replicated to Check that IPInfo-related user properties aren't replicated to publicly accessible databases.Sep 22 2021, 5:14 PM
phuedx renamed this task from Check that IPInfo-related user properties aren't replicated to publicly accessible databases to [SPIKE: ] Check that IPInfo-related user properties aren't replicated to publicly accessible databases.
phuedx added a project: Spike.
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptSep 22 2021, 5:15 PM

The PrefUpdate table via the PrefUpdate instrument

Having linked to the code that defines the instrument, I was reminded that it'd been changed so that only allowlisted properties are logged.

Niharika renamed this task from [SPIKE: ] Check that IPInfo-related user properties aren't replicated to publicly accessible databases to [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases.Sep 23 2021, 7:15 AM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
ARamirez_WMF renamed this task from [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases to [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H].Sep 29 2021, 4:16 PM
phuedx claimed this task.
phuedx added a subscriber: STran.

I was reminded of this task while combing through the IP Info board today. I think @STran mentioned this elsewhere but

The wiki replicas

Quoting https://wikitech.wikimedia.org/wiki/Help:Toolforge/Database#Redacted_tables:

The majority of the zuser_propertiesz table has been deemed sensitive and removed from the Wiki Replica databases. Only the disableemail, fancysig, gender, and nickname properties are available.

I'm being bold and resolving this task.