Page MenuHomePhabricator

Check if Status::isGood() and Status::isOk() are used appropriately in FileRepo
Closed, ResolvedPublic


Author: Bryan.TongMinh

Almost always you want Status::isGood() not Status::isOk(). Each use of those functions needs to be checked in FileRepo, because I have found cases where I believe isGood() is more appropriate than isOk(). In addition in some cases the member variable $ok is accessed directly. This should be fixed to use one of the accessor methods.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:13 PM
bzimport set Reference to bz27161.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

LocalFileMoveBatch done in r83245; LocalFileRestoreBatch done earlier.

MaxSem added a comment.Mar 5 2011, 2:30 PM

isOK() is grossly misleading, can we rename it?

aaron added a comment.Jan 15 2014, 1:12 AM

Is there anything to do here?

Bryan.TongMinh wrote:


Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM