Page MenuHomePhabricator

WikibaseRepo and WikibaseClient should not require loading default or example settings files
Open, Stalled, Needs TriagePublic5 Estimated Story Points

Description

Split from T97012 in storytime. See that task for more details

Acceptance Criteria: πŸ•οΈπŸŒŸ(September 2021)

  • Users loading either WikibaseRepo or WikibaseClient do not need to also require default / example settings files

Event Timeline

Change 723615 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Wikibase@master] Remove useless code comments and unreachable statements in examples

https://gerrit.wikimedia.org/r/723615

Change 723616 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Wikibase@master] client: Remove default configs in the example file

https://gerrit.wikimedia.org/r/723616

Change 723615 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove useless code comments and unreachable statements in examples

https://gerrit.wikimedia.org/r/723615

Change 723616 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Remove default configs in the example file

https://gerrit.wikimedia.org/r/723616

Change 726873 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove example config for termbox

https://gerrit.wikimedia.org/r/726873

Change 726917 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove shared cache key config from repo example config

https://gerrit.wikimedia.org/r/726917

Change 726920 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove extremely outdated comment from repo example config

https://gerrit.wikimedia.org/r/726920

With the changes uploaded so far, all the things remaining in Wikibase.example.php are related to namespaces (define the namespaces, declare them, register them as entity sources, and mark them to be searched by default). We don’t want to do that unconditionally in the default settings, but we can probably introduce a setting like defaultEntityNamespaces, and try setting up the namespaces in an extension callback. (We should watch out that we don’t run into T288819: NamespaceInfo service missing namespaces if initialized too early.)

Change 727366 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move namespace registration out of example settings (mostly)

https://gerrit.wikimedia.org/r/727366

Change 726917 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove shared cache key config from repo example config

https://gerrit.wikimedia.org/r/726917

Change 726920 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove extremely outdated comment from repo example config

https://gerrit.wikimedia.org/r/726920

Change 727366 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move namespace registration out of example settings (mostly)

https://gerrit.wikimedia.org/r/727366