Page MenuHomePhabricator

Vector 2022 search bar is missing "Search WIKI [Alt+Shift+f]" tooltip when focused, hindering discovery of access key
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Move mouse over the search box.

What happens?:

  • No tooltip.

What should have happened instead?:
*A tooltip appears, reading "Search $WIKI [Alt+Shift+f]".

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

QA Results - Beta

ACStatusDetails
1T291671#7981814

QA Results - Prod

ACStatusDetails
1T291671#7997353

Event Timeline

Jdlrobson added a subscriber: Jdrewniak.

I thought this was a recent regression, relating to current work, but it's not so putting back in backlog for more assessment. It looks like the title attribute was intentionally removed in bd8339865 (T264355@Jdrewniak do you remember the reason?

Jdlrobson subscribed.
ovasileva lowered the priority of this task from High to Medium.Oct 12 2021, 9:23 PM
ovasileva subscribed.

Moving to sprint board in order to group with other tooltip issues

Jdlrobson renamed this task from Post-2019 Vector search bar is missing "Search WIKI [Alt+Shift+f]" tooltip to Vector 2022 search bar is missing "Search WIKI [Alt+Shift+f]" tooltip when focused.Mar 14 2022, 5:44 PM
Jdlrobson added a subscriber: alexhollender_WMF.

Let's talk about this in estimation. My understanding is this is an intentional design decision to remove the tooltip - possibly as it's redundant (often the same as the placeholder text). I recognize it's different, but it's not clear to me what problem we'd be solving by restoring it. @alexhollender_WMF any thoughts?

In legacy Vector:

Screen Shot 2022-03-25 at 10.13.08 AM.png (166×640 px, 19 KB)

In modern Vector if we were to retain it:

Screen Shot 2022-03-25 at 10.13.27 AM.png (164×1 px, 32 KB)

@Suzukaze-c thanks for pointing this inconsistency out.

@Jdlrobson in legacy vector the tooltip seems to show the keyboard shortcut:

image.png (178×658 px, 30 KB)

aside from exposing the shortcut I'm not sure what the value is, though maybe it's related to accessibility? @Volker_E @Sarai-WMDE @bmartinezcalvo

note that Google search has a similar tooltip:

image.png (644×1 px, 89 KB)

My understanding is that we mainly use the title attributes for providing short descriptive text and instructions for accesskeys, I don't believe there's any other value besides that. Modern Vector has icons buttons, where the title attribute is slightly more useful, but in this case I believe it's mostly a matter of consistency with legacy Vector.

From an accessibility point of view 'title' attributes generally aren't recommended, they aren't read by most screenreaders and have poor browser support, among other issues. Not to say that's an argument to get rid of the title attributes, just that they dont add any value specific to accessibility (ideally we'd provide the same descriptive text and instructions via accessible tooltips rather than title attributes)

Agreed, from a pure accessibility perspective probably not. From a consistency point of view, if we feature this (seemingly power user) feature in other places (Vector 2022?) of the interface, why getting rid of it in some place without pain?
The value I see and I've mostly understood this is, that users simply get informed in a non-obstructed way about speeding up their user journey by using accesskeys. How many users are using it/learning to use it is on a different page without data.

T291671#7377209 @Jdrewniak do you remember why we removed it?

Line 69 of App.vue in bd833986599 features this comment /** The access key informational tip for search. */

Jdlrobson renamed this task from Vector 2022 search bar is missing "Search WIKI [Alt+Shift+f]" tooltip when focused to Vector 2022 search bar is missing "Search WIKI [Alt+Shift+f]" tooltip when focused, hindering discovery of access key.May 10 2022, 4:03 PM
bwang removed bwang as the assignee of this task.Jun 3 2022, 7:08 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 802820 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add back search title to WVUI component

https://gerrit.wikimedia.org/r/802820

Change 802820 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add back search title to WVUI component

https://gerrit.wikimedia.org/r/802820

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome, Firefox
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Search tooltip should appear after hovering over search field.

Screen Shot 2022-06-05 at 7.09.03 PM.png (257×1 px, 57 KB)

Screen Shot 2022-06-05 at 7.09.56 PM.png (302×1 px, 69 KB)

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome, Firefox
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Search tooltip should appear after hovering over search field.

Screen Shot 2022-06-12 at 5.24.13 PM.png (186×843 px, 31 KB)

Screen Shot 2022-06-12 at 5.23.52 PM.png (185×741 px, 31 KB)