Page MenuHomePhabricator
Create Task
Maniphest T29170

[Installer] Install does not complete when choosing a CC license
Closed, ResolvedPublic
Actions

Description

So I went through the "Select a custom Creative Commons license" selector to pick CC-SA-unported and when I was clicked "continue" I was thrown back on the page with "Choose which Creative Commons license you want and click "proceed"." (never mind that I had clicked "proceed" in the CC picker).

Also it forgot which extensions I selected to have enabled so I had to re-choose them.

Version: 1.18.x
Severity: normal

Details

Reference
bz27170

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 21 2014, 11:14 PM
• bzimport added a project: MediaWiki-Installer.
• bzimport set Reference to bz27170.
MarkAHershberger created this task.Feb 5 2011, 1:10 AM
• brion added a comment.Mar 27 2011, 8:13 PM

There were two things breaking this:

  • X-Frame-Options forbade our final step of the license selector, or the license selection shower, from being loaded properly. This lead to it looking wrong.
  • The installation URL fingerprinting broke on the long query string that's on the final step. As a result, the user's selection got saved into a different session subkey, thinking it belonged to a different installation. It would then not get seen by the surrounding page's installer instance, causing the confusion.

Fix removes the X-Frame-Options for the CC bit, and drops query strings before the rest of URL normalization in the fingerprint check so the CC bits now see the same session key as the rest.

Fixed in r84881.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL