Remove unused jquery.mw-jump module
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Sep 25 2021, 2:20 AM

Description

In T195256: Implement accessibility jump links with pure CSS in 1.32, the jquery.mw-jump module was removed as a dependency of mediawiki.page.ready in favor of having individual skins be responsible for handling any jump links with the suggestion to use pure css instead of the javascript module.
Per codesearch, it is not used anywhere. Can we drop it? And if so, do we need a period with deprecation warnings first?

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove unused `jquery.mw-jump` module	mediawiki/core	master	+1 -19

Customize query in gerrit

Related Objects

Mentioned Here: T195256: Implement accessibility jump links with pure CSS

Event Timeline

DannyS712 created this task.Sep 25 2021, 2:20 AM

Restricted Application added projects: Performance-Team, User-DannyS712. · View Herald TranscriptSep 25 2021, 2:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Krinkle edited projects, added MediaWiki-User-Interface; removed Performance-Team, MediaWiki-ResourceLoader.Sep 25 2021, 3:13 AM

This module is one of hundreds stored in the MediaWiki repository, but it is not part of the ResourceLoader library. See also the Phabricator description for MediaWiki-ResourceLoader.

In T291720#7377577, @Krinkle wrote:

This module is one of hundreds stored in the MediaWiki repository, but it is not part of the ResourceLoader library. See also the Phabricator description for MediaWiki-ResourceLoader.

Woops, sorry. Tagged out of habit for my other patches dealing with trying to help with RL cleanup and removal of unneeded code.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Sep 25 2021, 5:02 AM

Change 723640 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove unused `jquery.mw-jump` module

https://gerrit.wikimedia.org/r/723640

gerritbot added a project: Patch-For-Review.Sep 25 2021, 5:15 AM

Selector mw-jump is still used by a few skins. And documentation in MW core is also still referring to it.
This should at minimum have an entry in RELEASE-NOTES and best-possibly get the core static files updated.

In T291720#7377998, @Volker_E wrote:

Selector mw-jump is still used by a few skins. And documentation in MW core is also still referring to it.
This should at minimum have an entry in RELEASE-NOTES and best-possibly get the core static files updated.

The class is used, but where do they load the module?

In T291720#7377999, @DannyS712 wrote:

In T291720#7377998, @Volker_E wrote:

Selector mw-jump is still used by a few skins. And documentation in MW core is also still referring to it.
This should at minimum have an entry in RELEASE-NOTES and best-possibly get the core static files updated.

The class is used, but where do they load the module