Text in Vector dropdown is too small (on Beta)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AntiCompositeNumber
	Sep 25 2021, 3:09 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Go to https://en.wikipedia.beta.wmflabs.org/wiki/File:Example.jpg?useskin=vector&useskinversion=1
Resize the window until a tab is moved into the More dropdown
Open the dropdown

What happens?:
The font size of the dropdown items is smaller than other tabs, and smaller than it currently is in production.

What should have happened instead?:

Dropdown items should have the same font size as other tabs.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

MediaWiki 1.38.0-alpha (3b5c598) 00:49, 25 September 2021
Vector	1.0.0 (ce1888e) 20:54, 24 September 2021

git bisect blames rSVECd4befe8c397c: Do not use User session in the constructor.

Details

	Subject	Repo	Branch	Lines +/-
	Vector menu items are wrapped in spans + improve Vector addPortletLink support	mediawiki/skins/Vector	master	+60 -7

Customize query in gerrit

Related Objects

Mentioned In: T281166: 1.38.0-wmf.2 deployment blockers
Mentioned Here: rSVECd4befe8c397c: Do not use User session in the constructor

Event Timeline

AntiCompositeNumber created this task.Sep 25 2021, 3:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2021, 3:09 AM

SuperHamster subscribed.Sep 25 2021, 4:23 AM

Change 723320 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Vector menu items are wrapped in spans + improve Vector addPortletLink support

https://gerrit.wikimedia.org/r/723320

gerritbot added a project: Patch-For-Review.Sep 25 2021, 5:01 AM

ovasileva triaged this task as High priority.Sep 27 2021, 5:33 PM

LGoto added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).Sep 27 2021, 5:34 PM

ovasileva subscribed.Sep 27 2021, 5:34 PM

Jdlrobson added a parent task: T281166: 1.38.0-wmf.2 deployment blockers.Sep 27 2021, 5:34 PM

LGoto assigned this task to Jdlrobson.Sep 27 2021, 5:34 PM

LGoto moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 723320 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Vector menu items are wrapped in spans + improve Vector addPortletLink support

https://gerrit.wikimedia.org/r/723320

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2021, 8:11 PM

@AntiCompositeNumber I believe this is fixed, but can you verif that for me?

It depends what gadgets have you got enabled here. It's possible if those gadgets are not using mw.util.addPortletLink they may still be impacted so I want to double check. If something is still broken could you point me to the gadgets you are using so I can take a closer look?

Jdlrobson moved this task from Doing to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 27 2021, 9:19 PM

Looks good on beta from here.