After mass deletion of translation pages, Translate extension creates pages with edit summary "Mass deletion of pages added by X"
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Shirayuki
	Sep 25 2021, 3:38 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Open Special:Contributions of a user
By clicking "mass delete" link, open Special:Nuke
Mass-delete pages (including translation pages)

What happens?:
The Translate extension creates pages with edit summary "Mass deletion of pages added by X".
Examples:
https://www.mediawiki.org/wiki/Special:Log?type=create&user=Clump&wpdate=2021-09-24&limit=500

What should have happened instead?:
Mass-deleted pages should be deleted.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid recreation of translation pages on bulk deletion of pages	mediawiki/extensions/Translate	master	+82 -26

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	abi_	T291724 After mass deletion of translation pages, Translate extension creates pages with edit summary "Mass deletion of pages added by X"
		Resolved	BUG REPORT	abi_	T312293 After all translations to a given locale are deleted, the localized page for that locale is not deleted

Event Timeline

Shirayuki created this task.Sep 25 2021, 3:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2021, 3:38 AM

Shirayuki updated the task description. (Show Details)Sep 25 2021, 4:33 AM

Mainframe98 subscribed.Sep 25 2021, 7:17 AM

In the hope that someone will soon delete the untranslated pages, I changed the link to point to the page creation log, which contains entries for deleted pages as well.

For investigation.

Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.Sep 27 2021, 6:08 AM

I am wondering why those translation pages were not created when the bad translations were made? Or were they but then deleted, how? Could someone with access to deleted revisions help to puzzle this together? Does Special:Nuke allow deleting the translation pages as well the translation unit pages?

My guess is that Special:Nuke allows deleting translation pages too (there is no check to prevent it, other than the web UI which offers to do it in a better way). If translation page is deleted before the translation unit page, then the deletion of the unit page triggers rebuild of the translation page.

If that's true, this is not a regression, just a long-standing bug.

Change 724010 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Remove English from disabled target language list

https://gerrit.wikimedia.org/r/724010

gerritbot added a project: Patch-For-Review.Sep 27 2021, 10:02 AM

Special:Nuke allows deletion of all types of pages including translatable page, translation pages and unit pages.

I was only able to reproduce this bug by first nuking the translation page, and then deleting the translation unit pages.

Special:Nuke lists pages in descending order of creation time.
Translation page will be deleted before some translation units.
After deleting translation unit #1, translation page will be re-created.