Page MenuHomePhabricator

Javascript config wgVisualEditorConfig.namespaces should not include null
Closed, ResolvedPublic

Description

In the javascript configuration variables in mw.config, wgVisualEditorConfig is an object with among other properties a namespaces entry where the namespaces that VisualEditor can be used in are included. However, currently on meta this includes null, which isn't an actual namespace. It comes from the generating code in ApiVisualEditor::getAvailableNamespaceIds using null for namespaces that don't exist - these should be filtered out at the end.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 723641 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/VisualEditor@master] Don't include `null` in the namespaces where VE can be enabled

https://gerrit.wikimedia.org/r/723641

Change 723641 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't include `null` in the namespaces where VE can be enabled

https://gerrit.wikimedia.org/r/723641

matmarex assigned this task to DannyS712.
matmarex added a subscriber: matmarex.

Thanks for the patch.