Page MenuHomePhabricator

Remove javascript config setting wgCommentByteLimit
Closed, ResolvedPublic


Currently, on all loads, when mw.config is set it includes an option wgCommentByteLimit that is always null. Per codesearch, this option is never used: I propose removing it.

First added in T185948: Update web UI for increased comment length as being either 255 or null, depending on the state of $wgCommentTableSchemaMigrationStage
In T166733: Deploy refactored comment storage when the migration state was removed, wgCommentByteLimit was changed to always be null
In rMW64bc98a56c84: Input length limit: Remove uses of wgCommentByteLimit the remaining uses of the config in core JS were removed. At the time, @Jdforrester-WMF

Should also remove from VE. (And a patch to remove it from RL, but Timo will probably want us to be nice to gadget owners and announce that again.)

In rEVED8a7860398832: Drop support for wgCommentByteLimit, hard-coded null in MW nowadays the VE use was removed.

I was unable to find a mention when searching tech news, but per global search its unused in onwiki code already,

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 723643 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Remove `wgCommentByteLimit` from mw.config

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

We can still include this in tech news if needed, just not sure it is

Change 723643 merged by jenkins-bot:

[mediawiki/core@master] resourceloader: Remove `wgCommentByteLimit` from mw.config