Page MenuHomePhabricator

Regression: Download PDF link is incorrectly styled
Closed, ResolvedPublicBUG REPORT

Description

NOTE: Regression relating to Minerva icon changes (T288678)

List of steps to reproduce (step by step, including full links if applicable):

The issue impacts both advanced mode ( in more menu) and non-advanced mode:

What happens?:
The "download in PDF" option is misaligned

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Screenshot_20210925-093215.jpg (960×540 px, 172 KB)

QA Results - Beta

ACStatusDetails
1T291739#7391486

QA Results - Prod

ACStatusDetails
1T291739#7393891

Event Timeline

Jdlrobson renamed this task from error in advanced mode to Regression: Download PDF link is incorrectly styled.Sep 27 2021, 4:40 PM
Jdlrobson updated the task description. (Show Details)

Change 724128 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix the download link to use addPortletLink

https://gerrit.wikimedia.org/r/724128

cjming moved this task from Code Review to QA on the Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
cjming added a subscriber: cjming.
Jdlrobson added a subscriber: Jdlrobson.

This is blocked on https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/723326
Due to a miscommunication that patch hasn't got merged yet.

Given this is marked as a train blocker that patch (and this one) must be merged ASAP.

Jdlrobson raised the priority of this task from High to Unbreak Now!.
Jdlrobson added a subscriber: Edtadros.

Change 724128 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix the download link to use addPortletLink

https://gerrit.wikimedia.org/r/724128

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Sep 28 2021, 5:04 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ Verify Download PDF link is properly aligned

Screen Shot 2021-09-30 at 7.00.00 AM.png (722×517 px, 133 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, hewiki, kowiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ Verify Download PDF link is properly aligned

Screen Shot 2021-09-30 at 5.45.51 PM.png (588×503 px, 128 KB)

Screen Shot 2021-09-30 at 5.41.23 PM.png (588×503 px, 97 KB)

Screen Shot 2021-09-30 at 5.41.12 PM.png (588×503 px, 161 KB)

Screen Shot 2021-09-30 at 5.43.21 PM.png (588×503 px, 157 KB)