Page MenuHomePhabricator
Create Task
Maniphest T291739

Regression: Download PDF link is incorrectly styled
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Edu
Sep 25 2021, 12:41 PM
Tags
Referenced Files
F34663401: Screen Shot 2021-09-30 at 5.41.12 PM.png
Oct 1 2021, 12:47 AM
F34663400: Screen Shot 2021-09-30 at 5.45.51 PM.png
Oct 1 2021, 12:47 AM
F34663402: Screen Shot 2021-09-30 at 5.41.23 PM.png
Oct 1 2021, 12:47 AM
F34663403: Screen Shot 2021-09-30 at 5.43.21 PM.png
Oct 1 2021, 12:47 AM
F34662753: Screen Shot 2021-09-30 at 7.00.00 AM.png
Sep 30 2021, 2:02 PM
F34653512: Screenshot_20210925-093215.jpg
Sep 25 2021, 12:41 PM
Subscribers
Aklapper
cjming
Edtadros
Edu
Jdlrobson
Masumrezarock100

Description

NOTE: Regression relating to Minerva icon changes (T288678)

List of steps to reproduce (step by step, including full links if applicable):

The issue impacts both advanced mode ( in more menu) and non-advanced mode:

What happens?:
The "download in PDF" option is misaligned

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Screenshot_20210925-093215.jpg (960×540 px, 172 KB)

QA Results - Beta

ACStatusDetails
1✅T291739#7391486

QA Results - Prod

ACStatusDetails
1✅T291739#7393891

Details

SubjectRepoBranchLines +/-
Fix the download link to use addPortletLinkmediawiki/skins/MinervaNeuemaster+49 -46
Customize query in gerrit

Related Objects

Event Timeline

Edu created this task.Sep 25 2021, 12:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2021, 12:41 PM
Jdlrobson renamed this task from error in advanced mode to Regression: Download PDF link is incorrectly styled.Sep 27 2021, 4:40 PM
Jdlrobson edited projects, added MinervaNeue, Web-Team-Backlog (Kanbanana-FY-2021-22), Regression; removed Advanced Mobile Contributions.
Jdlrobson updated the task description. (Show Details)
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptSep 27 2021, 4:40 PM
Jdlrobson moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 27 2021, 4:40 PM
Jdlrobson moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson triaged this task as High priority.Sep 27 2021, 5:01 PM
gerritbot added a comment.Sep 27 2021, 5:03 PM

Change 724128 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fix the download link to use addPortletLink

https://gerrit.wikimedia.org/r/724128

gerritbot added a project: Patch-For-Review.Sep 27 2021, 5:03 PM
Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 27 2021, 5:31 PM
LGoto assigned this task to cjming.Sep 27 2021, 5:32 PM
cjming reassigned this task from cjming to Edtadros.Sep 27 2021, 7:13 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
Jdlrobson moved this task from QA to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 27 2021, 11:13 PM
Jdlrobson subscribed.

This is blocked on https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/723326
Due to a miscommunication that patch hasn't got merged yet.

Given this is marked as a train blocker that patch (and this one) must be merged ASAP.

Jdlrobson removed Edtadros as the assignee of this task.Sep 27 2021, 11:14 PM
Jdlrobson raised the priority of this task from High to Unbreak Now!.
Jdlrobson added a subscriber: Edtadros.
gerritbot added a comment.Sep 27 2021, 11:51 PM

Change 724128 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix the download link to use addPortletLink

https://gerrit.wikimedia.org/r/724128

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 28 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 28 2021, 12:10 AM
Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Sep 28 2021, 5:04 PM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson assigned this task to Edtadros.Sep 28 2021, 5:07 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 30 2021, 2:02 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ Verify Download PDF link is properly aligned

Screen Shot 2021-09-30 at 7.00.00 AM.png (722×517 px, 133 KB)

Edtadros updated the task description. (Show Details)Sep 30 2021, 2:03 PM
Edtadros reassigned this task from Edtadros to ovasileva.Oct 1 2021, 12:47 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, hewiki, kowiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ Verify Download PDF link is properly aligned

Screen Shot 2021-09-30 at 5.45.51 PM.png (588×503 px, 128 KB)

Screen Shot 2021-09-30 at 5.41.23 PM.png (588×503 px, 97 KB)

Screen Shot 2021-09-30 at 5.41.12 PM.png (588×503 px, 161 KB)

Screen Shot 2021-09-30 at 5.43.21 PM.png (588×503 px, 157 KB)

Edtadros updated the task description. (Show Details)Oct 1 2021, 12:48 AM
ovasileva closed this task as Resolved.Oct 1 2021, 4:31 PM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL