Page MenuHomePhabricator
Create Task
Maniphest T291768

CdnCacheUpdate defaults to port 1080 on MediaWiki >= 1.35
Open, Needs TriagePublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Set $wgCdnServers[] to an IP address or hostname with no port specified
  • Trigger a CdnCacheUpdate

What happens?:

cURL attempts to connect to the CDN server on port 1080.

What should have happened instead?:

cURL attempts to connect to the CDN server on port 80.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

This is because the SquidPurgeClient that was in use defaulted to port 80. With the change to using MultiHttpClient for T250417, we now use cURL, and pass the $wgCdnServer as the proxy parameter. cURL defaults to port 1080 if no port is specified.

Related Objects

Event Timeline

ineffyble created this task.Sep 26 2021, 5:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2021, 5:15 AM
ineffyble added a comment.Sep 26 2021, 5:16 AM

I suspect the simplest fix would be to append :80 to what we pass to cURL if the server doesn't contain a port already.

Justin_C_Lloyd subscribed.Dec 1 2021, 11:48 AM
Justin_C_Lloyd added a comment.Dec 1 2021, 11:50 AM

I just found this bug report. I'd always been confused why I'd never see any PURGE requests coming into my wiki web servers' Varnish processes (via varnishlog -q 'ReqMethod eq PURGE'), and why I was seeing port 1080 instead of the expected 80 when viewing page purges through tcpdump. I can confirm that adding :80 to each of the IP addresses in my $wgCdnServers setting does indeed resolve the problem for me.

Justin_C_Lloyd mentioned this in T132538: isConfiguredProxy not recognizing $wgSquidServers with port.Dec 1 2021, 12:13 PM
Mcapodici subscribed.Sep 6 2022, 5:53 AM

Notes: See also https://www.mediawiki.org/wiki/Topic:Wgai3z6vhfr9sq4m., I have updated the documentation for the wgCdnServers manual page.

Justin_C_Lloyd added a comment.Apr 6 2023, 10:06 PM

The comments in MainConfigSchema.php still also say that port 80 is the default for CdnServers:
https://github.com/wikimedia/mediawiki/blob/master/includes/MainConfigSchema.php#L4434

Taylan subscribed.Sep 22 2025, 8:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits