Page MenuHomePhabricator
Create Task
Maniphest T291776

Edit tags containing newlines
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
matmarex
Authored By
1234qwer1234qwer4
Sep 26 2021, 11:28 AM
Tags
Referenced Files
F34659277: image.png
Sep 27 2021, 1:25 PM
F34659274: image.png
Sep 27 2021, 1:25 PM
F34659272: image.png
Sep 27 2021, 1:25 PM
F34655048: tag name linebreaks.png
Sep 26 2021, 11:28 AM
Subscribers
1234qwer1234qwer4
Aklapper
AntiCompositeNumber
matmarex

Description

Before https://commons.wikimedia.org/wiki/MediaWiki:Tag-Blocked_user_editing_own_talk_page was created by @AntiCompositeNumber, the Blocked user editing own talk page tag on Commons (as listed at Special:Tags) appeared the following way on history and diff pages (but not at Special:Contributions):

tag name linebreaks.png (118×324 px, 3 KB)

It appears that the MediaWiki message contained unnecessary linebreaks by default.

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.38.0-wmf.1+2 -2ChangeTags: Set interface flag when parsing tag names
mediawiki/coremaster+2 -2ChangeTags: Set interface flag when parsing tag names
Customize query in gerrit

Related Objects
Search...

Event Timeline

1234qwer1234qwer4 created this task.Sep 26 2021, 11:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2021, 11:28 AM
AntiCompositeNumber added a project: MediaWiki-Page-history.Sep 26 2021, 2:56 PM

More specifically, the default tag name was wrapped in <p></p>.

matmarex added a project: DiscussionTools.EditedSep 27 2021, 1:25 PM
matmarex added a subscriber: matmarex.

The bug is still reproducible using some other tags, e.g. "wikilove":

It looks very similar to T291460 and T291590. The broken markup comes from DiscussionTools:

image.png (2×3 px, 604 KB)

matmarex added a parent task: T291833: Fix regressions caused by DiscussionTools page transformations.Sep 27 2021, 1:40 PM
gerritbot added a comment.Sep 27 2021, 2:16 PM

Change 724075 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724075

gerritbot added a project: Patch-For-Review.Sep 27 2021, 2:16 PM
matmarex claimed this task.Sep 27 2021, 2:19 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 27 2021, 3:28 PM
DLynch added a project: Editing QA.
gerritbot added a comment.Sep 27 2021, 3:46 PM

Change 724075 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724075

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2021, 4:10 PM
1234qwer1234qwer4 added a comment.Sep 27 2021, 4:51 PM
In T291776#7380207, @matmarex wrote:

The broken markup comes from DiscussionTools:

For reference, I do not have DiscussionTools enabled.

matmarex added a comment.Sep 27 2021, 5:03 PM

That's normal, as noted in T273072, everyone is supposed to get the same markup now, and it includes some DiscussionTools stuff. (But not on history pages!)

gerritbot added a comment.Sep 27 2021, 5:33 PM

Change 724110 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.38.0-wmf.1] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724110

gerritbot added a project: Patch-For-Review.Sep 27 2021, 5:33 PM
matmarex added a comment.Sep 27 2021, 5:34 PM

Backport scheduled: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210927T1800

gerritbot added a comment.Sep 27 2021, 6:27 PM

Change 724110 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.1] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724110

Stashbot added a comment.Sep 27 2021, 6:32 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-27T18:32:03Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.1/includes/changetags/ChangeTags.php: rMWb1f4b4e45b37: ChangeTags: Set interface flag when parsing tag names (T291776) (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.1; 2021-09-21); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2021, 7:10 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 27 2021, 10:30 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Sep 27 2021, 10:33 PM
gerritbot added a comment.Sep 28 2021, 5:56 PM

Change 724484 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

https://gerrit.wikimedia.org/r/724484

gerritbot added a project: Patch-For-Review.Sep 28 2021, 5:56 PM
matmarex removed a project: Patch-For-Review.Sep 28 2021, 5:57 PM

(Oops, ignore that patch, wrong task number)

ppelberg closed this task as Resolved.Oct 16 2021, 1:03 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL