Page MenuHomePhabricator

Edit tags containing newlines
Closed, ResolvedPublicBUG REPORT

Description

Before https://commons.wikimedia.org/wiki/MediaWiki:Tag-Blocked_user_editing_own_talk_page was created by @AntiCompositeNumber, the Blocked user editing own talk page tag on Commons (as listed at Special:Tags) appeared the following way on history and diff pages (but not at Special:Contributions):

tag name linebreaks.png (118×324 px, 3 KB)

It appears that the MediaWiki message contained unnecessary linebreaks by default.

Event Timeline

More specifically, the default tag name was wrapped in <p></p>.

matmarex added a subscriber: matmarex.

The bug is still reproducible using some other tags, e.g. "wikilove":

It looks very similar to T291460 and T291590. The broken markup comes from DiscussionTools:

image.png (2×3 px, 604 KB)

Change 724075 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724075

Change 724075 merged by jenkins-bot:

[mediawiki/core@master] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724075

The broken markup comes from DiscussionTools:

For reference, I do not have DiscussionTools enabled.

That's normal, as noted in T273072, everyone is supposed to get the same markup now, and it includes some DiscussionTools stuff. (But not on history pages!)

Change 724110 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.38.0-wmf.1] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724110

Change 724110 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.1] ChangeTags: Set interface flag when parsing tag names

https://gerrit.wikimedia.org/r/724110

Mentioned in SAL (#wikimedia-operations) [2021-09-27T18:32:03Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.1/includes/changetags/ChangeTags.php: b1f4b4e45b37792534e0aef4e636a26c369cc6a8: ChangeTags: Set interface flag when parsing tag names (T291776) (duration: 00m 56s)

Change 724484 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

https://gerrit.wikimedia.org/r/724484

(Oops, ignore that patch, wrong task number)