Page MenuHomePhabricator

Remove afl_filter column from the views
Closed, ResolvedPublic

Description

afl_filter column will be removed from production (T291719) so this column needs to be removed from the views, as otherwise all SELECTs will fail.
This removal needs to happen before we remove the column from production.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 723808 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/puppet@production] maintain-views.yaml: Remove afl_filter from the view

https://gerrit.wikimedia.org/r/723808

I have sent the above ^ patch which I believe it is all that is needed (apart from re-creating the views). Please feel free to merge and recreate the views.

rook triaged this task as Medium priority.

announced in cloud-announce that this will be done on 2021-10-06

Change 723808 merged by Michael DiPietro:

[operations/puppet@production] maintain-views.yaml: Remove afl_filter from the view

https://gerrit.wikimedia.org/r/723808

Same will be needed on clouddb1020.eqiad.wmnet when it is back in operation.

mdipietro@cumin1001:~$ sudo cumin 'A:wikireplicas-all and not D{clouddb1020.eqiad.wmnet}' 'run-puppet-agent -q'
8 hosts will be targeted:
clouddb[1013-1019,1021].eqiad.wmnet
Ok to proceed on 8 hosts? Enter the number of affected hosts to confirm or "q" to quit 8
===== NO OUTPUT =====                                                                                                                                                                                                                                                          
PASS 
|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████
████████████████████████████████████████████████████████████████████| 100% (8/8) [00:37<00:00,  4.34s/hosts]          
FAIL |                                                                                                                                                                                                                               |   0% (0/8) [00:37<?, ?hosts/s]
100.0% (8/8) success ratio (>= 100.0% threshold) for command: 'run-puppet-agent -q'.
100.0% (8/8) success ratio (>= 100.0% threshold) of nodes successfully executed all commands.
mdipietro@cumin1001:~$ sudo cumin 'A:wikireplicas-all and not D{clouddb1020.eqiad.wmnet}' '/usr/local/sbin/maintain-views --table abuse_filter_log --all-databases --replace-all'
8 hosts will be targeted:
clouddb[1013-1019,1021].eqiad.wmnet
Ok to proceed on 8 hosts? Enter the number of affected hosts to confirm or "q" to quit 8
===== NODE GROUP =====                                                                                                                
(1) clouddb1021.eqiad.wmnet                                                                                                           
----- OUTPUT of '/usr/local/sbin/...es --replace-all' -----                                                                           
2021-10-06 18:56:25,362 INFO Full views for enwiki:                                                                                   
2021-10-06 18:56:25,362 INFO Custom views for enwiki:                                                                                 
2021-10-06 18:56:25,365 INFO [enwiki_p.abuse_filter_log] 
2021-10-06 18:56:25,375 INFO Full views for bgwiki:
2021-10-06 18:56:25,375 INFO Custom views for bgwiki:
...
================                                                                                                                      
PASS |██████████████████████████████████████████████████████████████████████████████| 100% (8/8) [00:13<00:00,  2.48s/hosts]          
FAIL |                                                                                      |   0% (0/8) [00:13<?, ?hosts/s]
100.0% (8/8) success ratio (>= 100.0% threshold) for command: '/usr/local/sbin/...es --replace-all'.
100.0% (8/8) success ratio (>= 100.0% threshold) of nodes successfully executed all commands.