Page MenuHomePhabricator

updateMenteeData.php runs weird queries
Closed, ResolvedPublic

Description

From deployment-db07 binlogs (copied and stringified at deployment-db07:/home/urbanecm/deployment-db07-bin.000012.txt):

nlwiki
DELETE /* GrowthExperiments\Maintenance\UpdateMenteeData::execute www-data@deploy... */ FROM `growthexperiments_mentee_data` WHERE mentee_id IN ('PaigeLinder492','BrodieRahman29','SvenS72419067415','NorrisMarrone','HymanPalafox502','OdellScanlon','KandaceDeaton9','LandonWolfgang2','LaceyThyer6','DorcasWalton8','CortezHammond','LashundaMatlock','EloiseBumgarner','HollieBurnell40','Hershel3825','NRYHellen8','BettyCastiglione','CristineHorst6','WinniePelletier','JillianW15','AdellHollick93','JillThrower30','MikeGilley71507','EulaConway','RachelRosman716','AldaWellman0864','TerraRamer088','ShaneFremont274','UweClouse4','AnastasiaHeadley','ZandraS141486799','SommerCanela9','LinnieGrano020','QOVTeodoro','HortenseMorgan0','ToddJennings72','Hilda303313','VidaNorfleet029','HeribertoHueber','JoellenGardener','QuentinBarton38','YolandaPinner','BonitaMcKelvy06','ErnestoGregson7','MarylinBar3','ChristinBrunning','OMOCandelaria','COHBeatris','NatalieCarington','MahaliaTildesley','NidaCounsel2993','Vickie77X97','JanelleBrumby','VivianHilton21','TraciWaechter5','Richelle5274','GudrunShields','ValarieWelsh8','ValorieLittler6','LilaDodds5','Carson89X48826','VernellStokes9','KinaOng87973','FlorrieCreason','BethKingsford','ConstancePriestl','AllisonQuiles06','FosterStallings','HilarioDwight9','SSNLuther57','Sylvester9556','CharlotteRounds','BernardoBerryhil','Charley53K','JuliusTempleton','MauriceKinsey4','Lanora80W4576057','AnastasiaStrempe','LloydDillon60','VitoCollette97','KimWhitford909','NoelStultz0','ChristianBleakle','CurtisSwartwood','Glinda30L0','VitoFqj3297','ColetteZro','TracieSchlenker','EvonneTarpley23','HeathMallory29','Dani319742768747','NovellaSunderlan','CorinneUmbagai','Damian1973','AbigailUnger854','AllanLombardo96','ClaraCaballero6','DarcyKillinger','RoseannChf','BrittnyMolino3','KermitDutcher03','BonnyRemington','EugeniaEmmer1','AlejandrinaCarre','MicheleCreer492','BritneyMoats6','LorettaBallinger','RevaRichardson','TheodoreE03','KimberleyWhitacr','DwightOqr0425','DewayneMcAuley9','Karl3518768392','ShellieFia','Isabella1753','ReginaRivenburg','KenH201177991515','LZTGaye785','JustinaHam','TiaBlank0679','LukasLarry4318','MarianoFnt','LeonorScruggs8','KimOcasio75708','KathleneCurrey7','KarlaRobe88','Perry71Q460428','AutumnWeatherly','AlmedaReinoso7','MarlonGarcia584','ElizabetKauper','KyleYta6595177','AFVMadeleine','LeroyBateson35','MosheVigano9788','CrystleBky','DaveSturdee','PamI715172','KatieBieber','RandellLetters','JannOreilly248','MyrtleTulloch32','MarieWexler799','Eleanore16Y','BrandenMusser3','NiklasTunbridge','SheilaFitzGibbon','FranceMcGowen94','MaxwellV20','LasonyaJ73','SimoneByron708','AlvinDbf99627518','MaritaTilley','FSURyan3679','UJAAvis521','Sebastian8283','ElizabethNugent','Letha87P458','MelindaEverett','RodrickSigler37','BrendaLyne6652','VeroniquePhelps','MelindaMcCorkind','DenisBrazil','SadieTmi587762','Glen77954227478','KassandraCollett','RosalinePigott','MLWDarrel9394388','ChristoperSparks','PatriceOno84329','EvelyneBauer1','ThurmanZyq','JaxonBlundell','ShannaLevey6','RuebenFalconer','DaveBucklin','ChristyValerio6','BlondellHockman','JaysonMcCoin085','VernaWoodson38','ElidaOSullivan9','Julissa5235','NadiaDuncan086','TracyMartell1','CarleyPitre3310','FannieWhittell','Fredric08M','JohnnyD74982','IzettaBustos','JordanKempton4','Danae38628489','CoralWaechter','CarmaA644826825','HectorWhitehurst','LizaHolleran','OtisAckman','Marylin8137','BrandenQuezada','TonyConger1953','SondraHust80','TeshaDuong1484','DianHanson9','DenishaM51','CharlaPfr5','VirgilioTerpstra','CesarSta423','BlakeKallas','LydiaLoch71521','HelenaGranier44','Wiley78045587','JanetteDostie','ReneThibodeau','LouWortman48','Madeleine0596','AutumnODriscoll','BettyMintz39','GradyLange428','IslaPil016','LillieSuggs04','OdetteMcCash019','RossBarrientos','ReubenFelder52','FKVJames95951','CodyKitterman8','DaveGallagher1','EzraIib972086636','KirbySorrells95','LashawndaMcCoin','LourdesStaley','EdytheYbs522','CornellMintz5','ChunEspino96','TawannaHosking','FlorenciaGardner','DebraWollstonecr','RichieRummel','KatherineMatson','BrandenMondalmi','Eden82O05031250','AntonettaArreola','KarolynPierce66','LeaChapa543631','EpifaniaHager46','MonteHalford','MiriamFerraro80','BetseyAstley7','MistyD9574','MBWAlbertha','AlphonseAdkins','RoxieBohr651','FLGVicki59234000','LashayAmadio123','RosemarieWestmor','MelinaLaster1','RalfMcCoin1','ZLROphelia','LasonyaLanglais','LeilaniBrothers','LashundaMacnaght','TahliaTully','TimmyBecnel3318','DaisyMaki7','LillyR34722283','CandyWaldock847','ReganTrommler8','JulietBueno1121','PorterVarney5','FranklynMoseley','ZulmaMcKie26583','KattieF0028138','DLBDarren32755','CaryWagner60','VaughnEby9785','Beryl5924193775','LucioDresdner4','BernardLtk','Jacklyn6519','MauraSchweitzer','BrigidaDorn986','LeonoraBeaumont','FloraKimber83','Jennifer4613','LoisLudwig06935','FredrickQuintana','IsaacSparrow62','BelindaFortune6','AnitaBallou2057','CarinHundley182','MiriamKlinger1','WeldonGreenway4','KatjaF88535476','AdeleNfs82704','DarioRosenberger','InaEdinburgh7','LuellaJ3465733','IonaPelzer165','PhillippHyw','PhyllisAkhurst7','JOPMargot94999','Angelika50L','MamieDeyoung76','FatimaSantana','Larae657214004','LeopoldoMondrago','EdmundoRangel68','IngridColburn','KennethFortune5','YZAJewel1783','BeatriceColey','ScottL021149366','KiaraGleadow97','OllieAble60932','ForrestRoof7489','KathieWing4474','RustyButler908','ShaunPaulk50','AlenaSaltau8','KentonSpargo08','ThaddeusStapleto','EvangelineWiese','BlondellHer','NealMjm9291839','Ellie46E6721736','DarbyTvq0859958','UXJCyril906892','Coy04L6396959','MarlonRabin','TyrellFreud336','JLVIola0420005','SamanthaP38','KatjaQ8966874','CNWJodi81996903','GusLockie635','VonnieMrz67','Efrain8639','NaomiDunham91','ZHHRosalie','CindiPethebridge','DoraDevlin615','TracyTudor33742','FredrickLaurantu','MagdaSchonell','LeighBrubaker8','MarisolN93','GayeJudy8347','IsabelTapia1819','SamJephcott','OllieZiu179970','MyronDejesus8','RobertHash4','AlyciaDingle56','RollandVoigt07','FlossieBlankinsh','MabelWaldman3','FranklynClinton','AltaCondon7','StefanieAckley','LeilaBurn3714','CandaceDeLaConda','Sheena0206','KayleeDon8','RosellaCaskey8','SiobhanMcCorkle','SherryHeld28034','TraceyRounds07','MaeRug5152','Gail443573846634','NapoleonNovotny','CarissaD30','FrancescoPrendiv','HarrisErnst252','EloyJefferis7','LoraPoate760','RoslynMarlowe69','SidneySchuhmache','PeteLetcher1','AndreHester484','ScotBleau117','GloryVillasenor','ErickInman0','SACHilton33714','ThaddeusQ19','MaxwellSchulz83','ErnestineQuintan','KristineAbj','Indiana28D','NevilleRowe','GregSaxon38','Robyn57B4416','MargaritoLuong','EllaSharland1','VirgilioSander','Jody51S20796937')X
nlwiki

This...doesn't look right. mentee_id is an int, there's no way it is going a string.

Event Timeline

Mentioned in SAL (#wikimedia-operations) [2021-09-27T16:01:54Z] <urbanecm> Livehack debugging at mwmaint1002 for T291836

Mentioned in SAL (#wikimedia-operations) [2021-09-27T16:08:30Z] <urbanecm> [urbanecm@mwmaint1002 ~]$ scap pull # T291836

Change 724096 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] updateMenteeData: Fix a typo

https://gerrit.wikimedia.org/r/724096

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Found it. array_filter isn't the same as array_map :-).

FTR, noticed this as part of T291658: updateMenteeData.php submits a lot of DB queries -- I was verifying the fix in beta's binlogs, and accidentally noticed this too :-).

Change 724096 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] updateMenteeData: Fix a typo

https://gerrit.wikimedia.org/r/724096