Maniphest T291849

Create a DatabaseBlockStoreFactory in order to make DatabaseBlockStore a proper cross-wiki store
Closed, ResolvedPublic
Actions

Description

DatabaseBlockStore can be used to insert Blocks into foreign databases. In order to make it a proper cross-wiki store a DatabaseBlockStoreFactory should be added and injected in order to get the correct DatabaseBlockStore when inserting a block into the database.

A LBFactory should be injected into DatabaseBlockStoreFactory which then injects the correct LoadBalancer into a DatabaseBlockStore.

The new DatabaseBlockStoreFactory should then be injected into BlockUser instead of DatabaseBlockStore. The block related methods should then get a wiki parameter, which is then used to fetch the correct store.

Details

	Subject	Repo	Branch	Lines +/-
	DatabaseBlock: Fetch correct DatabaseBlockStore	mediawiki/core	master	+6 -2
	Don't allow passing a db to DatabaseBlockStore::insertBlock	mediawiki/core	master	+16 -106
	Deprecate passing a db to DatabaseBlockStore::insertBlock()	mediawiki/core	master	+15 -0
	Introduce a DatabaseBlockStoreFactory	mediawiki/core	master	+265 -37
	Properly place cross-wiki suppressions	mediawiki/extensions/CentralAuth	master	+4 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Security	• Pchelolo	T281972 ActorStore::checkDatabaseDomain: InvalidArgumentException: DB connection domain does not match when suppressing via Special:CentralAuth (CVE-2021-36128)
		Resolved	Security	Zabe	T284873 Regression: CentralAuth Lock+Suppress is issuing local blocks without autoblock
		Open		Zabe	T291994 Properly support cross-wiki blocking
		Resolved		Zabe	T291849 Create a DatabaseBlockStoreFactory in order to make DatabaseBlockStore a proper cross-wiki store

Event Timeline

Zabe created this task.Sep 27 2021, 3:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2021, 3:44 PM

Change 724091 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Introduce a DatabaseBlockStoreFactory

https://gerrit.wikimedia.org/r/724091

gerritbot added a project: Patch-For-Review.Sep 27 2021, 3:48 PM

Zabe updated the task description. (Show Details)Sep 27 2021, 8:50 PM

Zabe added a subtask: T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware..Sep 27 2021, 9:17 PM

Zabe triaged this task as High priority.Sep 28 2021, 6:26 PM

Zabe mentioned this in T291994: Properly support cross-wiki blocking.

Zabe added a parent task: T291994: Properly support cross-wiki blocking.

DannyS712 closed this task as a duplicate of T255433: Introduce a DatabaseBlock factory service.Sep 29 2021, 3:48 PM

Ugg, sorry, apparently I can't read, not a duplicate

Zabe mentioned this in T270559: DatabaseBlockStore::updateBlock should accept IDatabase as a parameter.Oct 4 2021, 5:05 PM

Zabe added a project: Anti-Harassment.Oct 17 2021, 8:45 PM

phuedx moved this task from Untriaged to MediaWiki-Blocks on the Anti-Harassment board.Oct 18 2021, 2:54 PM

Zabe removed a subtask: T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware..Jan 17 2022, 11:11 PM

Zabe mentioned this in T298223: Global suppressions throw 'Deprecated cross-wiki access' warnings.Jan 20 2022, 10:50 AM

Change 756135 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Deprecate passing a db to DatabaseBlockStore::insert()

https://gerrit.wikimedia.org/r/756135

Zabe removed a project: User-Zabe.Apr 13 2022, 12:49 AM

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 19: The Deerstalker); removed Anti-Harassment.Nov 7 2022, 5:44 PM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Deerstalker) board.

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 19: The Sanbenito); removed Anti-Harassment (AHaT Sprint 19: The Deerstalker).Nov 8 2022, 5:23 AM

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 19: The Sanbenito) board.

Tchanders edited projects, added Anti-Harassment; removed Anti-Harassment (AHaT Sprint 19: The Sanbenito).Nov 9 2022, 5:18 PM

Change 724091 merged by jenkins-bot:

[mediawiki/core@master] Introduce a DatabaseBlockStoreFactory

https://gerrit.wikimedia.org/r/724091

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 14 2023, 8:00 PM

Change 889289 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Properly place cross-wiki suppressions

https://gerrit.wikimedia.org/r/889289

Change 889289 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Properly place cross-wiki suppressions

https://gerrit.wikimedia.org/r/889289

Change 756135 merged by jenkins-bot:

[mediawiki/core@master] Deprecate passing a db to DatabaseBlockStore::insertBlock()

https://gerrit.wikimedia.org/r/756135

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 12:11 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 20 2023, 1:00 PM

Zabe closed this task as Resolved.Jun 10 2023, 7:53 PM

Umherirrender mentioned this in T258866: Calling DatabaseBlock::insert with a particular database may perform actions on the wrong database.Jun 14 2023, 7:11 PM

Zabe merged a task: T258866: Calling DatabaseBlock::insert with a particular database may perform actions on the wrong database.Jun 15 2023, 5:50 AM

Zabe added subscribers: Tchanders, Umherirrender.

Change 985615 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Don't allow passing a db to DatabaseBlockStore::insertBlock

https://gerrit.wikimedia.org/r/985615

gerritbot added a project: Patch-For-Review.Dec 25 2023, 11:14 AM

Change 985615 merged by jenkins-bot:

[mediawiki/core@master] Don't allow passing a db to DatabaseBlockStore::insertBlock

https://gerrit.wikimedia.org/r/985615

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 12 2024, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2024, 1:31 AM

Change 998601 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] DatabaseBlock: Fetch correct DatabaseBlockStore for autoblock

https://gerrit.wikimedia.org/r/998601

gerritbot added a project: Patch-For-Review.Feb 8 2024, 1:12 AM

Change 998601 merged by jenkins-bot:

[mediawiki/core@master] DatabaseBlock: Fetch correct DatabaseBlockStore

https://gerrit.wikimedia.org/r/998601

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 3:31 AM