Page MenuHomePhabricator
Create Task
Maniphest T291875

Remove MinervaTemplate::getSecondaryActions
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
bwang
Authored By
Jdlrobson
Sep 27 2021, 7:25 PM
Tags
Referenced Files
F34714642: Screen Shot 2021-10-28 at 3.40.40 PM.png
Oct 28 2021, 10:41 PM
F34714640: Screen Shot 2021-10-28 at 3.38.58 PM.png
Oct 28 2021, 10:39 PM
F34710324: Screen Shot 2021-10-25 at 7.17.11 AM.png
Oct 25 2021, 2:19 PM
F34710323: Screen Shot 2021-10-25 at 7.17.43 AM.png
Oct 25 2021, 2:19 PM
Subscribers
Aklapper
bwang
cjming
Edtadros
Izno
Jdlrobson
Masumrezarock100
ovasileva

Description

The MinervaTemplate::getSecondaryActionsHtml method should be moved into minerva.mustache. We should reuse any core data as much as we possibly can. If needed add new data to SkinMinerva::getTemplateData.

TODO

  • The MinervaTemplate::getSecondaryActions method should not exist. Move to SkinMinerva if needed.
  • The MinervaTemplate::isFallbackEditor method should not exist. Move to SkinMinerva if needed.
  • secondaryactionshtml should not be present in the template data sent to Minerva's Mustache template.
  • The SkinMinerva::getSecondaryActions method should not use BaseTemplate $tpl
  • The line $tpl->set( 'secondary_actions' in SkinMinerva should no longer exist.

QA

Visit the main page and check the language button and talk buttons display.

QA Results - Beta

ACStatusDetails
1✅T291875#7466949

QA Results - Prod

ACStatusDetails
1✅T291875#7466955

Details

SubjectRepoBranchLines +/-
Remove MinervaTemplate::getSecondaryActionsmediawiki/skins/MinervaNeuemaster+28 -55
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson triaged this task as Medium priority.Sep 27 2021, 7:25 PM
Jdlrobson created this task.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.Sep 28 2021, 8:49 PM
Jdlrobson updated the task description. (Show Details)Sep 30 2021, 5:26 PM
LGoto set the point value for this task to 3.Sep 30 2021, 5:28 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)Oct 4 2021, 10:18 PM
Jdlrobson moved this task from Milestone: More flexibility in article heading area (subpages, descriptions) to Minerva: Remove MinervaTemplate on the MediaWiki-Core-Skin-Architecture board.Oct 12 2021, 6:26 PM
bwang claimed this task.Oct 18 2021, 8:23 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Oct 20 2021, 8:07 PM

Change 732377 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Remove MinervaTemplate::getSecondaryActions

https://gerrit.wikimedia.org/r/732377

gerritbot added a project: Patch-For-Review.Oct 20 2021, 8:07 PM
bwang removed bwang as the assignee of this task.Oct 20 2021, 8:07 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 21 2021, 1:07 AM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 21 2021, 4:13 PM
Jdlrobson claimed this task.Oct 21 2021, 5:24 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 21 2021, 11:08 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Oct 22 2021, 6:47 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros added a comment.Oct 23 2021, 1:33 AM

@Jdlrobson is this ready for test in beta?

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.EditedOct 25 2021, 2:19 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit the main page and check the language button and talk buttons display.

Screen Shot 2021-10-25 at 7.17.43 AM.png (1×1 px, 303 KB)

Screen Shot 2021-10-25 at 7.17.11 AM.png (1×1 px, 343 KB)

Edtadros updated the task description. (Show Details)Oct 25 2021, 2:19 PM
bwang added a comment.Oct 25 2021, 5:33 PM

@Edtadros Sorry, this actually isn't ready to test yet, I'll move back to code review

bwang removed Edtadros as the assignee of this task.Oct 25 2021, 5:34 PM
bwang moved this task from QA in Prod to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang added a subscriber: Edtadros.
gerritbot added a comment.Oct 25 2021, 7:32 PM

Change 732377 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove MinervaTemplate::getSecondaryActions

https://gerrit.wikimedia.org/r/732377

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 25 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 25 2021, 8:11 PM
bwang assigned this task to Edtadros.Oct 25 2021, 8:17 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

@Edtadros Ok its ready now for testing on beta!

Jdlrobson removed Edtadros as the assignee of this task.Oct 26 2021, 10:24 PM
Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson assigned this task to Edtadros.Oct 27 2021, 1:45 AM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 28 2021, 10:39 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit the main page and check the language button and talk buttons display.

Screen Shot 2021-10-28 at 3.38.58 PM.png (1×956 px, 343 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Oct 28 2021, 10:41 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Visit the main page and check the language button and talk buttons display.

Screen Shot 2021-10-28 at 3.40.40 PM.png (1×912 px, 247 KB)

Edtadros updated the task description. (Show Details)Oct 28 2021, 10:42 PM
LGoto reassigned this task from ovasileva to cjming.Nov 2 2021, 5:06 PM
LGoto added a subscriber: ovasileva.
cjming closed this task as Resolved.Nov 4 2021, 2:36 AM

lgtm - checked latest master for removed methods and they no longer exist

cjming reassigned this task from cjming to bwang.Nov 4 2021, 2:37 AM
cjming subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL