Page MenuHomePhabricator
Create Task
Maniphest T291882

[wmf.1] Help panel guided tour autoadvances in background
Closed, ResolvedPublic
Actions

Description

  1. On mobile Homepage, select non-structured tasks and click on a task card.
  2. The Help panel will be present in a collapsed state. Wait for several seconds, open the Help panel, the Help panel guided tour will not be on the first step.

Notes:

  • The issue is present for a recommended link task too (the question mark icon should be clicked)
  • The issue is present on Desktop too, but less noticeable - the Help panel is in un-collapsed state when a user lands on an article page.
  • The guided Help panel tour should not advance to a different step when the panel is collapsed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Help panel: Auto-advance guidance when the help panel is opened from mobile peekmediawiki/extensions/GrowthExperimentsmaster+5 -0
Help panel: Don't auto-advance guidance when the panel is closedmediawiki/extensions/GrowthExperimentsmaster+18 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 27 2021, 7:59 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 27 2021, 7:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from [wmf.1] Help panel autoadvances in background to [wmf.1] Help panel guided tour autoadvances in background.Sep 27 2021, 8:00 PM
• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 28 2021, 8:27 PM
• mewoph added a subscriber: MMiller_WMF.Sep 28 2021, 10:02 PM

Hi @Etonkovidova @RHo @MMiller_WMF — I wanted to clarify the requirements for auto-advancing of the suggested edit tips

From T253009: Newcomer tasks: automatically advance tips:

The tips auto-advance every five seconds until the user has interacted with the panel in some way. Once the user interacts with the panel, the tips stay on whichever one they were on when the user interacted. This specification extends across the reading and editing experiences, i.e. if the user has not interacted with the panel in read mode, the tips should still be auto-advancing when the user gets to edit mode.

Should there be exceptions to this rule (i.e., no auto-advance) for

  1. both structured & unstructured tasks on mobile

and/or

  1. structured tasks on desktop

where the help panel starts in the collapsed state (and the initial opening of the help panel counts as an interaction)?

RHo added a comment.Sep 29 2021, 12:59 PM
In T291882#7386158, @mewoph wrote:

Hi @Etonkovidova @RHo @MMiller_WMF — I wanted to clarify the requirements for auto-advancing of the suggested edit tips

From T253009: Newcomer tasks: automatically advance tips:

The tips auto-advance every five seconds until the user has interacted with the panel in some way. Once the user interacts with the panel, the tips stay on whichever one they were on when the user interacted. This specification extends across the reading and editing experiences, i.e. if the user has not interacted with the panel in read mode, the tips should still be auto-advancing when the user gets to edit mode.

Should there be exceptions to this rule (i.e., no auto-advance) for

  1. both structured & unstructured tasks on mobile

and/or

  1. structured tasks on desktop

where the help panel starts in the collapsed state (and the initial opening of the help panel counts as an interaction)?

Hi @mewoph, I'd say yes for both – there should be no auto-advance if the help panel is collapsed regardless of structured/unstructured and platform.

• mewoph moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 30 2021, 8:27 PM
• mewoph claimed this task.Sep 30 2021, 9:15 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Sep 30 2021, 10:00 PM

Change 725123 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Help panel: Don't auto-advance guidance when the panel is closed

https://gerrit.wikimedia.org/r/725123

gerritbot added a project: Patch-For-Review.Sep 30 2021, 10:00 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 30 2021, 10:02 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 1 2021, 5:07 AM
gerritbot added a comment.Oct 1 2021, 5:22 AM

Change 725123 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help panel: Don't auto-advance guidance when the panel is closed

https://gerrit.wikimedia.org/r/725123

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2021, 6:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 1 2021, 5:21 PM
Etonkovidova added a comment.Oct 4 2021, 9:27 PM

Tested on betalabs Desktop for a new account.

@mewoph - please review the current behavior below. Does it match to what the patch was supposed to do?
The current behavior:

  • (a structured task): a user lands on a page - the Help panel is closed; a user opens the Help panel - no auto-advancing.
  • (non-structured task): a user lands on a page - the Help panel is open and the auto-advanicng is visible. A user closes the panel, re-opens it - the steps were auto-advancing while the panel was closed.
• mewoph added a comment.Oct 4 2021, 9:39 PM

Hi @Etonkovidova, for structured task, the behavior is correct. For unstructured task, auto-advance should not occur once the user closes the panel. Do you happen to know if this was happening before the change? The patch should only impact the help panel when it starts off closed, so it shouldn't change anything when the help panel starts off opened.

Etonkovidova added a comment.EditedOct 4 2021, 11:40 PM
In T291882#7400430, @mewoph wrote:

Hi @Etonkovidova, for structured task, the behavior is correct. For unstructured task, auto-advance should not occur once the user closes the panel. Do you happen to know if this was happening before the change? The patch should only impact the help panel when it starts off closed, so it shouldn't change anything when the help panel starts off opened.

Thank you for clarification! Yes, the scope of the task is fixed for the two cases when the Help (guidance) panel is initially presented in a collapsed state and a user does not interact with the panel (not opening it):

  • ✅ stop auto-advancing on mobile for Help panel
  • ✅ stop auto-advancing on Desktop for Help panel for a structured task (link recommendation)

This prevents a scenario when users land on a page (with the Help panel in a collapsed state) and spend sometime on a page, then open the Help panel and are faced, say, with the step number 4.

Two more points
(1) When the Help panel is opened on betalabs mobile, the Help panel tips do not auto-advance. Is this intentional?

(2) A user views the Help panel with auto-advancing and a user closes it on, for example, the step 3. Then, when a user re-opens it, a displayed step might be any step (the steps are auto-advancing while the panel was collapsed). Filed as a separate task - T292561: Help panel guidance tips - make state for tips step persistent when Help panel is closed

• mewoph added a comment.EditedOct 5 2021, 5:32 PM

Per meeting discussion: another distinction needs to be made re: mobile peek.

If the user opens the help panel from from the mobile peek, the guidance should auto-advance.

If the user closes the mobile peek and then open the help panel via CTA button, the guidance should not auto-advance.

Issue (2) will be filed as a separate issue.

Etonkovidova mentioned this in T292561: Help panel guidance tips - make state for tips step persistent when Help panel is closed.Oct 5 2021, 5:41 PM
• mewoph moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 5 2021, 5:44 PM
gerritbot added a comment.Oct 5 2021, 6:06 PM

Change 726670 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Help panel: Auto-advance guidance when the help panel is opened from mobile peek

https://gerrit.wikimedia.org/r/726670

gerritbot added a project: Patch-For-Review.Oct 5 2021, 6:06 PM
• mewoph added a comment.Oct 5 2021, 6:11 PM

Opening help panel via mobile peek:

Opening help panel via CTA:

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 5 2021, 6:11 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 6 2021, 8:20 AM
gerritbot added a comment.Oct 6 2021, 8:35 AM

Change 726670 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Help panel: Auto-advance guidance when the help panel is opened from mobile peek

https://gerrit.wikimedia.org/r/726670

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 6 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2021, 9:10 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 7 2021, 12:57 AM
Etonkovidova closed this task as Resolved.Oct 14 2021, 12:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits