Page MenuHomePhabricator

Logo doesn't scale with font-size
Closed, ResolvedPublic2 Estimated Story Points

Description

When I increase the font-size in the settings of my browser, it is expected that the logo scales accordingly.

Screen Shot 2021-09-27 at 3.08.23 PM.png (560×1 px, 56 KB)

Screen Shot 2021-09-27 at 3.09.06 PM.png (1×2 px, 220 KB)

The Mustache data for logos contains a style attribute that can be rendered to resolve this. We have done this in Minerva and should also do this here.

QA steps

Event Timeline

Change 719599 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Logo scales with font-size

https://gerrit.wikimedia.org/r/719599

ovasileva triaged this task as Medium priority.Sep 28 2021, 5:17 PM
Jdlrobson removed the point value for this task.
LGoto set the point value for this task to 2.Sep 28 2021, 5:39 PM
cjming added a subscriber: cjming.

Change 719599 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Logo scales with font-size

https://gerrit.wikimedia.org/r/719599

Edtadros added a subscriber: Edtadros.

@Jdlrobson I don't think this was meant to stay assigned to me in Design Review. Assigning it to you so it doesn't get lost.

Jdlrobson added a subscriber: alexhollender.

@alexhollender can you take a look at this first on beta cluster and then move to QA column?

Looks good, tested across a couple of different language wikis as well