Page MenuHomePhabricator
Create Task
Maniphest T291953

TypeError: Return value of WikimediaBadges\WikibaseClientSiteLinksForItemHandler::getItem() must be an instance of Wikibase\DataModel\Entity\Item, null returned
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Return value of WikimediaBadges\WikibaseClientSiteLinksForItemHandler::getItem() must be an instance of Wikibase\DataModel\Entity\Item, null returned
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(212)
#0 /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(194): WikimediaBadges\WikibaseClientSiteLinksForItemHandler->getItem(Wikibase\DataModel\Entity\ItemId)
#1 /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(147): WikimediaBadges\WikibaseClientSiteLinksForItemHandler->getCommonsSitelinkFromMainSnaks(array, Wikibase\DataModel\Entity\ItemId, Wikibase\DataModel\Entity\NumericPropertyId)
#2 /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(112): WikimediaBadges\WikibaseClientSiteLinksForItemHandler->getLinkedItemSitelink(Wikibase\DataModel\Entity\Item, string)
#3 /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(89): WikimediaBadges\WikibaseClientSiteLinksForItemHandler->getCommonsSiteLink(Wikibase\DataModel\Entity\Item)
#4 /srv/mediawiki/php-1.38.0-wmf.1/extensions/WikimediaBadges/includes/WikibaseClientSiteLinksForItemHandler.php(81): WikimediaBadges\WikibaseClientSiteLinksForItemHandler->doProvideSiteLinks(Wikibase\DataModel\Entity\Item, array)
#5 /srv/mediawiki/php-1.38.0-wmf.1/includes/HookContainer/HookContainer.php(338): WikimediaBadges\WikibaseClientSiteLinksForItemHandler::provideSiteLinks(Wikibase\DataModel\Entity\Item, array, Wikibase\Client\Usage\RedirectTrackingUsageAccumulator)
#6 /srv/mediawiki/php-1.38.0-wmf.1/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#7 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(113): MediaWiki\HookContainer\HookContainer->run(string, array)
#8 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(104): Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForItem(Wikibase\DataModel\Entity\Item)
#9 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/SiteLinksForDisplayLookup.php(82): Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForItemId(Wikibase\DataModel\Entity\ItemId)
#10 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/LangLinkHandler.php(266): Wikibase\Client\Hooks\SiteLinksForDisplayLookup->getSiteLinksForPageTitle(Title)
#11 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/LangLinkHandler.php(287): Wikibase\Client\Hooks\LangLinkHandler->getEffectiveRepoLinks(Title, ParserOutput)
#12 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandler.php(85): Wikibase\Client\Hooks\LangLinkHandler->addLinksFromRepository(Title, ParserOutput)
#13 /srv/mediawiki/php-1.38.0-wmf.1/extensions/Wikibase/client/includes/Hooks/ParserOutputUpdateHookHandler.php(67): Wikibase\Client\Hooks\ParserOutputUpdateHookHandler->doContentAlterParserOutput(Title, ParserOutput)
#14 /srv/mediawiki/php-1.38.0-wmf.1/includes/HookContainer/HookContainer.php(160): Wikibase\Client\Hooks\ParserOutputUpdateHookHandler->onContentAlterParserOutput(WikitextContent, Title, ParserOutput)
#15 /srv/mediawiki/php-1.38.0-wmf.1/includes/HookContainer/HookRunner.php(1203): MediaWiki\HookContainer\HookContainer->run(string, array)
#16 /srv/mediawiki/php-1.38.0-wmf.1/includes/content/AbstractContent.php(552): MediaWiki\HookContainer\HookRunner->onContentAlterParserOutput(WikitextContent, Title, ParserOutput)
#17 /srv/mediawiki/php-1.38.0-wmf.1/includes/Revision/RenderedRevision.php(266): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#18 /srv/mediawiki/php-1.38.0-wmf.1/includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#19 /srv/mediawiki/php-1.38.0-wmf.1/includes/Revision/RevisionRenderer.php(217): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#20 /srv/mediawiki/php-1.38.0-wmf.1/includes/Revision/RevisionRenderer.php(154): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#21 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#22 /srv/mediawiki/php-1.38.0-wmf.1/includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#23 /srv/mediawiki/php-1.38.0-wmf.1/includes/poolcounter/PoolWorkArticleView.php(137): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#24 /srv/mediawiki/php-1.38.0-wmf.1/includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#25 /srv/mediawiki/php-1.38.0-wmf.1/includes/page/ParserOutputAccess.php(281): PoolCounterWork->execute()
#26 /srv/mediawiki/php-1.38.0-wmf.1/includes/page/Article.php(697): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#27 /srv/mediawiki/php-1.38.0-wmf.1/includes/page/Article.php(509): Article->generateContentOutput(User, ParserOptions, integer, OutputPage, array)
#28 /srv/mediawiki/php-1.38.0-wmf.1/includes/actions/ViewAction.php(74): Article->view()
#29 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(538): ViewAction->show()
#30 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(320): MediaWiki->performAction(Article, Title)
#31 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(925): MediaWiki->performRequest()
#32 /srv/mediawiki/php-1.38.0-wmf.1/includes/MediaWiki.php(559): MediaWiki->main()
#33 /srv/mediawiki/php-1.38.0-wmf.1/index.php(53): MediaWiki->run()
#34 /srv/mediawiki/php-1.38.0-wmf.1/index.php(46): wfIndexMain()
#35 /srv/mediawiki/w/index.php(3): require(string)
#36 {main}
Impact

47 occurrences since 2021-09-25 (1.38.0-wmf.1).

Notes

Details

Request URL
https://en.wikipedia.org/wiki/Panadura_Royal_College
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Handle missing items in WikibaseClientSiteLinksForItemHandlermediawiki/extensions/WikimediaBadgeswmf/1.38.0-wmf.2+21 -3
Handle missing items in WikibaseClientSiteLinksForItemHandlermediawiki/extensions/WikimediaBadgeswmf/1.38.0-wmf.1+21 -3
Handle missing items in WikibaseClientSiteLinksForItemHandlermediawiki/extensions/WikimediaBadgesmaster+21 -3
Customize query in gerrit

Event Timeline

Ladsgroup created this task.Sep 28 2021, 2:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2021, 2:32 PM
Ladsgroup lowered the priority of this task from Unbreak Now! to Needs Triage.Sep 28 2021, 2:32 PM
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Sep 28 2021, 2:36 PM
Michael subscribed.Sep 28 2021, 2:41 PM
Ladsgroup moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Sep 28 2021, 2:48 PM
Lucas_Werkmeister_WMDE claimed this task.Sep 29 2021, 10:03 AM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Sep 29 2021, 10:08 AM

Change 724710 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaBadges@master] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724710

gerritbot added a project: Patch-For-Review.Sep 29 2021, 10:08 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 29 2021, 10:08 AM
gerritbot added a comment.Sep 29 2021, 3:01 PM

Change 724710 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@master] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724710

gerritbot added a comment.Sep 29 2021, 3:08 PM

Change 724560 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaBadges@wmf/1.38.0-wmf.1] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724560

gerritbot added a comment.Sep 29 2021, 3:08 PM

Change 724561 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaBadges@wmf/1.38.0-wmf.2] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724561

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 4:00 PM
gerritbot added a comment.Sep 29 2021, 4:19 PM

Change 724560 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@wmf/1.38.0-wmf.1] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724560

gerritbot added a comment.Sep 29 2021, 4:19 PM

Change 724561 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@wmf/1.38.0-wmf.2] Handle missing items in WikibaseClientSiteLinksForItemHandler

https://gerrit.wikimedia.org/r/724561

Stashbot added a comment.Sep 29 2021, 4:24 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-29T16:24:01Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.1/extensions/WikimediaBadges/: Backport: [[gerrit:724560|Handle missing items in WikibaseClientSiteLinksForItemHandler (T291953)]] (duration: 01m 10s)

Stashbot added a comment.Sep 29 2021, 4:25 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-29T16:25:21Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.2/extensions/WikimediaBadges/: Backport: [[gerrit:724561|Handle missing items in WikibaseClientSiteLinksForItemHandler (T291953)]] (duration: 01m 08s)

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 29 2021, 4:26 PM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 5:00 PM
Addshore moved this task from Inbox to Active on the [DEPRECATED] wdwb-tech board.Oct 4 2021, 12:23 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 13 2021, 9:16 AM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Doesn’t seem to be happening anymore, I think we can close this.

Screenshot 2021-10-13 at 11-16-12 mediawiki - Elastic.png (220×678 px, 10 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits