Maniphest T291967

Regression: Redirects from moves no longer tagged as new redirects
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

Move page A to B

What happens?: The redirect at A is not tagged as a new redirect.

What should have happened instead?: The redirect at A is tagged as a new redirect.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Might have been caused by T291677.
Originally, I considered reopening T184117, but that task has since been closed again.

Details

	Subject	Repo	Branch	Lines +/-
	PageUpdater: apply tags even if RC suppressed.	mediawiki/core	wmf/1.38.0-wmf.7	+33 -0
	PageUpdater: apply tags even if RC suppressed.	mediawiki/core	master	+33 -0

Customize query in gerrit

Related Objects

Mentioned Here: T184117: Tag redirects from moves as new redirects
T291677: Do not generate RecentChanges entries for redirects from page moves

Event Timeline

GTrang created this task.Sep 28 2021, 4:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2021, 4:32 PM

GTrang updated the task description. (Show Details)Sep 28 2021, 4:34 PM

IKhitron subscribed.Sep 30 2021, 6:35 PM

Adding relevant subscribers from T291677 (@Legoktm and @Pchelolo).

• Pchelolo claimed this task.Oct 1 2021, 4:39 PM

• Pchelolo added a project: Platform Team Workboards (MW Expedition).

GTrang added a project: MW-1.38-release.Oct 8 2021, 8:40 PM

Change 736881 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] PageUpdater: apply tags even if RC suppressed.

https://gerrit.wikimedia.org/r/736881

gerritbot added a project: Patch-For-Review.Nov 4 2021, 8:40 PM

Change 736881 merged by jenkins-bot:

[mediawiki/core@master] PageUpdater: apply tags even if RC suppressed.

https://gerrit.wikimedia.org/r/736881

• Pchelolo closed this task as Resolved.Nov 5 2021, 3:18 PM

@Pchelolo Could you cherry-pick (backport) the patch to 1.38.0-wmf.7 as well?

Not on Friday unfortunately. No deployments on Fridays.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 5 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 4:10 PM

So then, we would have to wait until Monday, November 8 before we could backport this to 1.38.0-wmf.7.

GTrang added a comment.Nov 8 2021, 3:43 PM

This comment was removed by GTrang.

In T291967#7485626, @Pchelolo wrote:

Not on Friday unfortunately. No deployments on Fridays.

@Pchelolo Today is Monday, and there are deployments on Mondays. So, could you now cherry-pick (backport) the patch to 1.38.0-wmf.7 as well?

Change 737085 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@wmf/1.38.0-wmf.7] PageUpdater: apply tags even if RC suppressed.

https://gerrit.wikimedia.org/r/737085

gerritbot added a project: Patch-For-Review.Nov 8 2021, 3:47 PM

Change 737085 abandoned by Ppchelko:

[mediawiki/core@wmf/1.38.0-wmf.7] PageUpdater: apply tags even if RC suppressed.

Reason:

not needed anymore