Maniphest T292030

[regression-wmf.2] VE icons displayed incorrectly on mobile
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 28 2021, 10:35 PM

Description

List of steps to reproduce

On testwiki wmf.2 mobile open VE in an article

What happens?: The icons are grouped on one side. And for Suggestions mode - the icons will overlap the label

Software version :

testwiki wmf.2 mobile
the same issue on iPhone and Android devices

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Search header should be vertically centered, not top aligned."	mediawiki/skins/MinervaNeue	master	+0 -3
	Revert "Search header should be vertically centered, not top aligned."	mediawiki/skins/MinervaNeue	wmf/1.38.0-wmf.2	+0 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T281166 1.38.0-wmf.2 deployment blockers
		Resolved	BUG REPORT	kostajh	T292030 [regression-wmf.2] VE icons displayed incorrectly on mobile

Event Timeline

Etonkovidova created this task.Sep 28 2021, 10:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2021, 10:35 PM

Etonkovidova added a project: Growth-Team.Sep 28 2021, 10:38 PM

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a parent task: T291833: Fix regressions caused by DiscussionTools page transformations.

MMiller_WMF subscribed.Sep 28 2021, 11:55 PM

kostajh added a parent task: T281166: 1.38.0-wmf.2 deployment blockers.Sep 29 2021, 8:19 AM

This seems like a deployment blocker, so setting parent task raising priority.

Note that the icon display issue is only visible on a narrow (ie phone sized) viewport, so just switching to mobile frontend won't be enough to reproduce the bug.

This doesn't seem related to T291833: Fix regressions caused by DiscussionTools page transformations (cc @Etonkovidova), rather it looks like a regression caused by rSMINd6d26e45bb0f: Search header should be vertically centered, not top aligned. (cc @Jdlrobson @nray)

Change 724552 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/skins/MinervaNeue@master] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724552

gerritbot added a project: Patch-For-Review.Sep 29 2021, 8:30 AM

matmarex removed a parent task: T291833: Fix regressions caused by DiscussionTools page transformations.Sep 29 2021, 10:03 AM

matmarex added a project: VisualEditor.

kostajh moved this task from Inbox to Triaged on the Growth-Team board.Sep 29 2021, 10:05 AM

Change 724553 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724553

Change 724552 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724552

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 11:00 AM

Change 724553 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724553

Mentioned in SAL (#wikimedia-operations) [2021-09-29T11:48:00Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.2/skins/MinervaNeue/skinStyles/mobile.startup/Overlay.less: Backport: [[gerrit:724553|Revert "Search header should be vertically centered, not top aligned." (T292030)]] (duration: 01m 07s)