Page MenuHomePhabricator

[regression-wmf.2] VE icons displayed incorrectly on mobile
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce

  • On testwiki wmf.2 mobile open VE in an article

What happens?: The icons are grouped on one side. And for Suggestions mode - the icons will overlap the label

IMG_0336.PNG (1×640 px, 161 KB)
IMG_0335.PNG (1×640 px, 179 KB)

Software version :

  • testwiki wmf.2 mobile
  • the same issue on iPhone and Android devices

Event Timeline

kostajh triaged this task as High priority.Sep 29 2021, 8:21 AM
kostajh added a subscriber: kostajh.

This seems like a deployment blocker, so setting parent task raising priority.

Note that the icon display issue is only visible on a narrow (ie phone sized) viewport, so just switching to mobile frontend won't be enough to reproduce the bug.

image.png (1×640 px, 197 KB)

Change 724552 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/skins/MinervaNeue@master] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724552

Change 724553 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724553

Change 724552 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724552

Change 724553 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Revert \"Search header should be vertically centered, not top aligned.\"

https://gerrit.wikimedia.org/r/724553

Mentioned in SAL (#wikimedia-operations) [2021-09-29T11:48:00Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.2/skins/MinervaNeue/skinStyles/mobile.startup/Overlay.less: Backport: [[gerrit:724553|Revert "Search header should be vertically centered, not top aligned." (T292030)]] (duration: 01m 07s)

kostajh claimed this task.

This is fixed; cc @Jdlrobson @nray.