Page MenuHomePhabricator

Highlight section header when linking to a section on Special:Preferences
Closed, ResolvedPublic

Description

T291002 introduced a link to the New Discussion and Reply Tools that, when clicked/tapped, will take people to Special:Preferences#mw-prefsection-editing-discussion.

This ticket is about extending that initial implementation to make it easier for people to more easily identify the settings that control the feature they are arriving to Special:Preferences wanting to inspect and/or change by highlighting the section header whenever linking to a section on Special:Preferences.

Requirements

This implementation will impact any link to specific sections within Special:Preferences.

Special:Preferences Links

  • Whenever people click/tap a link to a particular section within Special:Preferences (e.g. #mw-prefsection-editing-editor), the heading of that section (e.g. Editor) should be visually distinguished in some way.

Discussion Tools

  • For people who are logged in, a link is added beneath the REPLY and NEW DISCUSSION TOOL'S Advanced shelf that, when clicked, takes people to Special:Preferences#mw-prefsection-editing-discussion
    • Upon landing at Special:Preferences#mw-prefsection-editing-discussion, people should see the Discussion pages heading Visually distinguished in some way, so that people know what settings control the tool they might be trying to customize or disable

Mockup

Event Timeline

Prioritization
This Editing-team will prioritize work on this task if/when we come to learn that volunteers report not knowing what settings withing Special:Preferences control how the Reply and New Discussion Tools behave and/or appear.

Change 723302 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Highlight section header when linking to a section on Special:Preferences

https://gerrit.wikimedia.org/r/723302

Change 723303 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Work around a Chrome bug with :target selector and Special:Preferences tabs

https://gerrit.wikimedia.org/r/723303

I found an old feature request for similar functionality for the Gadgets tab in Preferences: T126962.

Drive-by comment from Design Systems person and reviewer of the patch:
I like the proposed change by @matmarex and agree with @ppelberg on the generalization.

  1. Wonder if the highlight needs to be persistent or could fade out after (f.e.) 3s?
  2. The highlight currently uses an Accent color, which we try to limit for interactive elements. Highlight should rather use a Yellow, like Yellow90. This would only work with a fade out though.

Regarding T291002#7372992 and the way the highlight in Special:Preferences#mw-prefsection-editing-discussionPreferences [i] behaves...

@matmarex, the changes you've implemented [ii] seem like they will help people to more easily identify the settings that are associated with the tool whose behavior they are wanting to change.

With this said, the more "permanent" nature of these changes (e.g. showing on every click as opposed to the first one, not fading, etc.) is leading me to see this as a bigger change and perhaps one that should be considered for Special:Preferences as a whole.

As such, to start I am thinking we should:

  1. Exclude all of the highlight-related changes from this initial change
  2. File a new ticket for introducing the highlight changes within Special:Preferences as a whole
  3. Consider prioritizing work on the to-be-filed ticket mentioned in "2." if/when people report having difficulty finding the settings associated with the New Discussion and/or Reply Tool.

...if any of the above seems problematic to you, please let me know.


i. Visual showing the highlight in preferencesii. Highlight behavior
Screen Shot 2021-09-27 at 10.45.56 AM.png (812×1 px, 172 KB)
1. Only the Discussion pages heading is highlighted [as opposed to the entire settings "group"), 2. Discussion pages is highlighted every time someone clicks the [[Special:Preferences#mw-prefsection-editing-discussionPreferences|Preferences]] link from within the New Discussion and Reply Tools, and 3. The highlight is shown on the page as long as someone is viewing it [as opposed to it being removed after some amount of time or action being taken]]

Drive-by comment from Design Systems person and reviewer of the patch:
I like the proposed change by @matmarex and agree with @ppelberg on the generalization.

  1. Wonder if the highlight needs to be persistent or could fade out after (f.e.) 3s?
  2. The highlight currently uses an Accent color, which we try to limit for interactive elements. Highlight should rather use a Yellow, like Yellow90. This would only work with a fade out though.

I've proposed persistent and blue to match the existing pattern used by links to references (e.g. https://en.wikipedia.org/wiki/Southwark_Street#cite_note-1).

Change 723302 merged by jenkins-bot:

[mediawiki/core@master] Highlight section header when linking to a section on Special:Preferences

https://gerrit.wikimedia.org/r/723302

Change 723303 merged by jenkins-bot:

[mediawiki/core@master] Work around a Chrome bug with :target selector and Special:Preferences tabs

https://gerrit.wikimedia.org/r/723303

Change 748275 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Revert \"Work around a Chrome bug with :target selector and Special:Preferences tabs\"

https://gerrit.wikimedia.org/r/748275

Change 748275 merged by jenkins-bot:

[mediawiki/core@master] Revert \"Work around a Chrome bug with :target selector and Special:Preferences tabs\"

https://gerrit.wikimedia.org/r/748275

Esanders added a subscriber: Esanders.

2nd patch was reverted so needs more work.

Change 748766 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Re-apply \"Work around a Chrome bug with :target selector and Special:Preferences tabs\"

https://gerrit.wikimedia.org/r/748766

Change 748766 merged by jenkins-bot:

[mediawiki/core@master] Re-apply \"Work around a Chrome bug with :target selector and Special:Preferences tabs\"

https://gerrit.wikimedia.org/r/748766

The heading is highlighted as expected. See screenshot for link to Special:Preferences#mw-prefsection-gadgets-gadget-section-appearance

Screenshot 2022-01-10 at 19.08.02.png (420×2 px, 104 KB)

ppelberg claimed this task.
ppelberg awarded a token.