There are two ResourceLoader modules, ext.echo.dm and ext.echo.logger, that are only loaded by and used in ext.echo.ui - these should be merged in, to reduce the module count and the size of the registry that is loaded on all views.
Note that the logger uses package files but ext.echo.ui doesn't yet, so that will be trickier to merge
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Merge ext.echo.dm module into ext.echo.ui | mediawiki/extensions/Echo | master | +17 -34 |
Initial plan:
merge .dm into .ui in the first patch, since they both use scripts - keep the name .ui since a bunch of skins add extra styles for that
Convert .ui to package files, with a very basic entry point that just require()s all of the individual scripts so that it essentially works like before, further cleanup to make use of package files feature to be done later
merge in .logger
No problem - is the growth team willing to review patches? I should be able to start on this within the next few days.
We can try to, but can't promise on timeliness of these reviews. Are you willing to handle any potential fallout (regressions, backports needed, etc) that may occur from merging these modules?
Sure, but I haven't noticed any fallout from the other 54 modules I've helped to merge or eliminate in the last few weeks, so I'm not anticipating any issues.
Change 727495 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Echo@master] Merge ext.echo.dm module into ext.echo.ui
I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.