Page MenuHomePhabricator
Create Task
Maniphest T292042

Merge UniversalLanguageSelector ResourceLoader modules to reduce module count
Open, Needs TriagePublic
Actions

Description

The following merges can be done to reduce modules:

  • combine jquery.webfonts and ext.uls.webfonts.repository, always loaded together (and then remove the ext.uls.webfonts.fonts module because all it does is depend on those two (now that combined one) and has none of its own anything)
  • combine ext.uls.i18n and ext.uls.messages by having the messages be set via a package file instead of the custom ResourceLoaderULSJsonMessageModule

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Merge jquery.webfonts into ext.uls.webfonts.repositorymediawiki/extensions/UniversalLanguageSelectormaster+6 -19
Customize query in gerrit

Event Timeline

DannyS712 created this task.Sep 29 2021, 3:17 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 29 2021, 3:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Sep 29 2021, 3:17 AM
Nikerabbit awarded a token.Sep 30 2021, 2:24 PM
gerritbot added a comment.Oct 15 2021, 11:33 PM

Change 731135 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/UniversalLanguageSelector@master] Merge jquery.webfonts into ext.uls.webfonts.repository

https://gerrit.wikimedia.org/r/731135

gerritbot added a project: Patch-For-Review.Oct 15 2021, 11:33 PM
DannyS712 updated the task description. (Show Details)Oct 15 2021, 11:37 PM
gerritbot added a comment.Oct 19 2021, 9:07 AM

Change 731135 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Merge jquery.webfonts into ext.uls.webfonts.repository

https://gerrit.wikimedia.org/r/731135

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 9:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 19 2021, 10:00 AM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:40 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits