Page MenuHomePhabricator

[Visual bug] Mobile search header is misaligned
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Visit any page
  • Type into search box

What happens?:

Screen Shot 2021-09-29 at 7.09.27 AM.png (582×1 px, 27 KB)

What should have happened instead?:

Screen Shot 2021-09-29 at 7.10.11 AM.png (464×1 px, 22 KB)

This misalignment impacts all overlay headers although is most noticeable on search.

Screen Shot 2021-09-29 at 7.12.06 AM.png (326×1 px, 91 KB)

Developer notes

Overlay headers historically used display: table but it appears to have been removed at some point in either MobileFrontend or Minerva

The rule can be added to .overlay.search-overlay .overlay-header however it seems VisualEditor is a special case, (see T292030)

Event Timeline

Change 724556 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Search header should be vertically centered, not top aligned.\"\"

https://gerrit.wikimedia.org/r/724556

Jdlrobson triaged this task as Unbreak Now! priority.Wed, Sep 29, 4:22 PM

Checked in with Olga and we want this fixed in this week's train.

Change 724787 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724787

Change 724556 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724556

Change 724787 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724787

Mentioned in SAL (#wikimedia-operations) [2021-09-29T18:52:33Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.2/skins/MinervaNeue/resources/skins.minerva.base.styles/ui.less: Backport: [[gerrit:724787|Search header should be vertically centered, not top aligned(take 2) (T292071)]] (duration: 01m 08s)

I also noticed that the size of the search field changes when it's tapped on tablet-size screens. Is this expected? As seen at https://m.mediawiki.org/wiki/MediaWiki:

image.png (2×3 px, 1 MB)
image.png (2×3 px, 127 KB)

This one is a longstanding issue and tracked in T285356.