Maniphest T292071

[Visual bug] Mobile search header is misaligned
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 29 2021, 2:16 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Visit any page
Type into search box

What happens?:

Screen Shot 2021-09-29 at 7.09.27 AM.png (582×1 px, 27 KB)

What should have happened instead?:

Screen Shot 2021-09-29 at 7.10.11 AM.png (464×1 px, 22 KB)

This misalignment impacts all overlay headers although is most noticeable on search.

Developer notes

Overlay headers historically used display: table but it appears to have been removed at some point in either MobileFrontend or Minerva

The rule can be added to .overlay.search-overlay .overlay-header however it seems VisualEditor is a special case, (see T292030)

Details

	Subject	Repo	Branch	Lines +/-
	Search header should be vertically centered, not top aligned(take 2)	mediawiki/skins/MinervaNeue	wmf/1.38.0-wmf.2	+5 -0
	Search header should be vertically centered, not top aligned(take 2)	mediawiki/skins/MinervaNeue	master	+5 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	jeena	T281166 1.38.0-wmf.2 deployment blockers
		Resolved	BUG REPORT	Jdlrobson	T292071 [Visual bug] Mobile search header is misaligned

Event Timeline

Jdlrobson created this task.Sep 29 2021, 2:16 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 29 2021, 2:16 PM

Change 724556 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Search header should be vertically centered, not top aligned.\"\"

https://gerrit.wikimedia.org/r/724556

gerritbot added a project: Patch-For-Review.Sep 29 2021, 2:16 PM

Jdlrobson updated the task description. (Show Details)Sep 29 2021, 2:18 PM

cjming added a project: Web-Team-Backlog.Sep 29 2021, 3:23 PM

Checked in with Olga and we want this fixed in this week's train.

Change 724787 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724787

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Sep 29 2021, 5:04 PM

Change 724556 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724556

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 6:00 PM

Jdlrobson added a parent task: T281166: 1.38.0-wmf.2 deployment blockers.Sep 29 2021, 6:18 PM

Jdlrobson mentioned this in T281166: 1.38.0-wmf.2 deployment blockers.

matmarex subscribed.Sep 29 2021, 6:32 PM

Change 724787 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.38.0-wmf.2] Search header should be vertically centered, not top aligned(take 2)

https://gerrit.wikimedia.org/r/724787

Mentioned in SAL (#wikimedia-operations) [2021-09-29T18:52:33Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.2/skins/MinervaNeue/resources/skins.minerva.base.styles/ui.less: Backport: [[gerrit:724787|Search header should be vertically centered, not top aligned(take 2) (T292071)]] (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.2; 2021-09-28); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2021, 7:10 PM

I also noticed that the size of the search field changes when it's tapped on tablet-size screens. Is this expected? As seen at https://m.mediawiki.org/wiki/MediaWiki:

This one is a longstanding issue and tracked in T285356.

Jdlrobson closed this task as Resolved.Sep 29 2021, 8:09 PM

Jdlrobson claimed this task.

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

matmarex mentioned this in T285356: [tablet/desktop] Minerva search bar blurs text and moves/shrinks slightly when focussed.Sep 29 2021, 8:22 PM

	F34661525: Screen Shot 2021-09-29 at 7.09.27 AM.png
	Sep 29 2021, 2:16 PM

	F34661529: Screen Shot 2021-09-29 at 7.10.11 AM.png
	Sep 29 2021, 2:16 PM

	F34661534: Screen Shot 2021-09-29 at 7.12.06 AM.png
	Sep 29 2021, 2:16 PM

	F34661855: image.png
	Sep 29 2021, 8:04 PM

	F34661853: image.png
	Sep 29 2021, 8:04 PM

[Visual bug] Mobile search header is misalignedClosed, ResolvedPublicBUG REPORTActions