Page MenuHomePhabricator

Introduce normalized performance metrics that help us better track aggregate performance across time
Open, MediumPublic

Description

Right now, we have wt2html and html2wt metrics on a per-request basis. However, in reality, these make it somewhat hard to use for understanding how performance changed over time since they depend on the composition of the requests. Lots of small requests might skew the metrics lower even when there has been no real performance gain and likewise if more large requests enter the mix, we see an upward trend which can give a false sense of performance degradation.

One idea is to track (a) time per KB of output HTML for wt2html requests (b) time per KB of processed input HTML for html2wt requests.

This will insulate metrics from being skewed by input/output sizes as well as the composition of the request set. As long as there are no serious contention effects from high request volumes, these metrics might provide us with a better handle on tracing performance changes over time.

Additionally, by pegging the metrics to HTML size rather than wikitext size, we get a more accurate performance picture since templates and extensions can have a small footprint in input and a large footprint in output.

Event Timeline

Arlolra triaged this task as Medium priority.Sep 30 2021, 3:01 PM
Arlolra moved this task from Needs Triage to Performance on the Parsoid board.

Change 725442 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Generate timing metrics per KB of HTML (output or input)

https://gerrit.wikimedia.org/r/725442

Change 725442 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Generate timing metrics per KB of HTML (output or input)

https://gerrit.wikimedia.org/r/725442

Change 729996 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.15.0-a3

https://gerrit.wikimedia.org/r/729996

Change 729996 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.15.0-a3

https://gerrit.wikimedia.org/r/729996