Page MenuHomePhabricator

Let PFFormUtils::buttonHTML to add classes to ButtonInputWidget (or, let save and continue button work)
Closed, ResolvedPublicBUG REPORT


List of steps to reproduce (step by step, including full links if applicable):

  • Create form.
  • Create page with form.
  • Enter again to edit page by form.
  • Click on "save and continue" button.

What happens?:

When editing page with form, save and continue not working, due its expected class html attributes not added in PHP code.

What should have happened instead?:

Html attributes would append to button so it'll work.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
MW 1.36, PageFroms and master

Bug affect
This bug is more than "save and continue" button thing, it can affect other functionalities now and on future

Event Timeline

Change 724837 had a related patch set uploaded (by Anysite; author: Anysite):

[mediawiki/extensions/PageForms@master] buttonHTML: add classes to button

Change 724837 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] buttonHTML: add classes to button

Yaron_Koren claimed this task.
Yaron_Koren added a subscriber: Yaron_Koren.

I think this is fixed now - that previous patch didn't really work, but now it should work.