Page MenuHomePhabricator

No name: "suggestionsEditMode", "save" (desktop)
Closed, ResolvedPublic

Description

I see these warnings when interacting with the link recommendation plugin:

grafik.png (116×744 px, 23 KB)

It comes from extensions/VisualEditor/lib/ve/src/ui/ve.ui.Toolbar.js:

// The parent method just rebuilds the tool groups so only
// do this if they have changed
if ( groups !== this.groups ) {
    // Parent method
    groups = groups.map( function ( group ) {
        if ( group.name ) {
            group.classes = group.classes || [];
            group.classes.push( 've-ui-toolbar-group-' + group.name );
        } else {
            OO.ui.warnDeprecation( 'No name: ' + JSON.stringify( group ) );
        }
        return group;
    } );
    ve.ui.Toolbar.super.prototype.setup.call( this, groups );
}

and that code hasn't been touched in a while, so it's probably something we've done in refactoring the link recommendation plugin code in T289211: Add Image: Generalize Add Link ResourceLoader modules and/or T290749: Add a link: Toolbar border is missing on desktop, the relevant line looks to be StructuredTaskDesktopArticleTarget.static.toolbarGroups = [ 'suggestionsEditMode', 'save' ];

Event Timeline

kostajh triaged this task as Medium priority.Sep 30 2021, 8:33 AM
kostajh created this task.

This is a deprecation warning from recent refactoring work, and also should be straightforward to fix, so I'm dropping into current sprint.

This is due to T290749: Add a link: Toolbar border is missing on desktop. The tool names were added to prevent empty toolbar class from being added. I think the issue is that these groups are there but they are added by the plugin later in the lifecycle.

Change 726941 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured Task: Don't override DesktopArticleTarget's toolbarGroups

https://gerrit.wikimedia.org/r/726941

mewoph renamed this task from No name: "suggestionsEditMode", "save" to No name: "suggestionsEditMode", "save" (desktop).Oct 6 2021, 5:01 PM
mewoph moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Change 726941 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured Task: Don't override DesktopArticleTarget's toolbarGroups

https://gerrit.wikimedia.org/r/726941