Enable data value normalization by default (remove tmpNormalizeDataValues repo setting)
Closed, ResolvedPublic
Actions

Description

As a third-party Wikibase admin, I want data values to be normalized on my wiki like they are on Wikidata.
As a Wikibase developer, I want tests to pass on my wiki without having to configure too many settings.

Problem:
In T251480, we implemented normalization of data values, but hid it behind a feature flag (tmpNormalizeDataValues). Now that we’ve rolled this out to all production wikis, we should remove that feature flag and unconditionally enable the feature. This is also relevant to developers, because we have an API integration test for the feature which assumes that the feature is enabled, and fails in a default Wikibase install.

Example:

Screenshots/mockups:

BDD
GIVEN
AND
WHEN
AND
THEN
AND

Acceptance criteria:

the tmpNormalizeDataValues repo setting is gone
data value normalization is enabled everywhere

Open questions:

Details

	Subject	Repo	Branch	Lines +/-
	Enable data value normalization by default	mediawiki/extensions/Wikibase	master	+23 -55

Customize query in gerrit

Related Objects

Mentioned Here: T251480: Normalize pagenames/filenames on save in Wikibase

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 30 2021, 12:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2021, 12:02 PM

We probably want to backport this to the REL1_37 branch too.

Lucas_Werkmeister_WMDE moved this task from Inbox to Triaged Medium (50+) on the [DEPRECATED] wdwb-tech board.Oct 5 2021, 12:39 PM

Change 761903 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Enable data value normalization by default

https://gerrit.wikimedia.org/r/761903

gerritbot added a project: Patch-For-Review.Feb 11 2022, 11:03 AM

In T292181#7703570, @gerritbot wrote:

Change 761903 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Enable data value normalization by default

https://gerrit.wikimedia.org/r/761903

(This is blocked on nothing other than some test failures that I haven’t had the time to look into yet.)

In T292181#7848031, @Lucas_Werkmeister_WMDE wrote:

(This is blocked on nothing other than some test failures that I haven’t had the time to look into yet.)

(Fixed now.)

CCing @Evelien_WMDE – I’m not sure if this should be prioritized from the product or tech side, but if it’s product then it probably belongs with Wikibase more than Wikidata. (Also CC @ItamarWMDE for the tech side.)

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptSep 27 2022, 9:03 AM

CCing @jon_amar-WMDE so they could decide if this is a product priority (seems more like suite than cloud to me).

ItamarWMDE moved this task from Radar to To Product on the User-ItamarWMDE board.Feb 22 2023, 10:56 AM

darthmon_wmde edited projects, added Wikibase Suite Team; removed User-ItamarWMDE, MediaWiki-extensions-WikibaseRepository, [DEPRECATED] wdwb-tech, Wikidata.Sep 13 2023, 11:06 AM

Lydia_Pintscher added a project: Wikidata.Sep 13 2023, 12:17 PM

darthmon_wmde moved this task from Inbox (anything we think of that we want to take into account) to Inherited Backlog on the Wikibase Suite Team board.Sep 22 2023, 2:43 PM

I just rebased the change again, it now adds the change to the release notes for 1.42 (since the branch for REL1_41 was cut the other day). Recall that when this task was originally filed, I had still hoped to get this into the 1.37 release (T292181#7391022), which in the meantime has gone through its entire lifecycle and is now EOL.

I don’t know what else I can do here. I don’t know why it’s seemingly impossible for us to remove this temporary feature flag. I don’t know how many more people need to be pinged to reach a decision about this. I don’t know why almost every third-party Wikibase for the last two years has still had data value normalization disabled when we haven’t had any problems with it being enabled on Wikidata.

Hey @Lucas_Werkmeister_WMDE, this issue is just now getting moved into the Suite teams backlog. I'm gathering that your patch has fallen "between the cracks" and meanwhile an important default remains wrong for now a few releases WikiBase.

On the dev side of the Suite team we have not yet submitted any patches via Gerrit to the Wikibase core, but do obviously expect to at some point. The attention hasn't been there yet. I think this may be a great first candidate for getting in there, which I am hopeful will be soon.

lojo_wmde moved this task from Inherited Backlog to Inbox (anything we think of that we want to take into account) on the Wikibase Suite Team board.Jan 8 2024, 11:25 AM

lojo_wmde moved this task from Inbox (anything we think of that we want to take into account) to Epic: Move adoption to a UX score of 3 for dev ops users. on the Wikibase Suite Team board.Feb 5 2024, 12:18 PM

darthmon_wmde moved this task from Epic: Move adoption to a UX score of 3 for dev ops users. to Next Focus (prioritised top to bottom + unrefined) on the Wikibase Suite Team board.Feb 6 2024, 3:52 PM

darthmon_wmde added a project: wbSuite Release Pipeline.

lojo_wmde moved this task from Next Focus (prioritised top to bottom + unrefined) to Sprint-∞ on the Wikibase Suite Team board.Mar 15 2024, 10:35 AM

lojo_wmde edited projects, added Wikibase Suite Team (Sprint-∞); removed Wikibase Suite Team.

darthmon_wmde edited projects, added Wikibase Suite Team; removed Wikibase Suite Team (Sprint-∞).Tue, Apr 2, 1:54 PM

Change #761903 merged by Loren Johnson:

[mediawiki/extensions/Wikibase@master] Enable data value normalization by default

https://gerrit.wikimedia.org/r/761903

Maintenance_bot removed a project: Patch-For-Review.Mon, Apr 8, 8:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Mon, Apr 8, 9:00 AM