Page MenuHomePhabricator

Inconsistent end-of-lines in 1.3.8 & HEAD
Closed, ResolvedPublic

Description

Author: zigger

Description:
Files in 1.3.8 & HEAD have inconsistent end-of-lines.

Inconsistent processing by different cvs clients & tar-unpackers results in
unnecessary diffs & in later corruption by text editors that assume consistency.

A. These files have CR-LF instead of LF
maintenance/archives/patch-cache.sql (also HEAD)
languages/LanguageNn.php

B. These files have both LF & CR-LF instead of LF

languages/wikipedia/de.lang
languages/wikipedia/en.lang
languages/wikipedia/fr.lang
languages/wikipedia/ja.lang
languages/wikipedia/nl.lang
languages/wikipedia/pl.lang

7-zip unpacked these from tar with both CR-LF & LF
WinZip with default "smarts" end-of-line translation produced consistent CR-LF
Windows cvs client (tortoise/cvsnt) fetched these with both CR & CR-LF


Version: 1.4.x
Severity: minor
OS: Windows 2000
Platform: PC

Details

Reference
bz922

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 7:03 PM
bzimport set Reference to bz922.
bzimport added a subscriber: Unknown Object (MLST).

Fixed patch-cache.sql and LanguageNn.php.

The *.lang files are pretty useless, I'm not sure why they ever got checked in. I've removed them.

zigger wrote:

LanguagEl.php also has inconsistent end-of-lines in both 1.4beta2 download and
cvs (REL1_4 & HEAD).

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:20 AM