Page MenuHomePhabricator

Deleting templates in narrow mode leads to deadlocks
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • open a multi-part template
  • delete the last/first template
  • repeat deleting the last/first parameter

What happens?:

When deleting the last parameter:
The template search appears but switching the view is not possible anymore.

Peek 2021-09-30 17-11.gif (630×516 px, 320 KB)

When deleting the first parameter:
The deletion of the last element is not possible because the delete button is inactive.

Peek 2021-09-30 17-05.gif (630×516 px, 39 KB)

What should have happened instead?:
All parameters should be deleted. The template search appears and switching the view is possible.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
new sidebar

Event Timeline

WMDE-Fisch set the point value for this task to 3.
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-29 board.

Change 725260 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Don't get stuck on a narrow mode sidebar

https://gerrit.wikimedia.org/r/725260

Change 725260 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't get stuck on a narrow mode sidebar

https://gerrit.wikimedia.org/r/725260

Change 725323 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Reduce duplicate/dead code when checking for single templates

https://gerrit.wikimedia.org/r/725323

Change 725323 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reduce duplicate/dead code when checking for single templates

https://gerrit.wikimedia.org/r/725323

Aklapper removed a subscriber: WMDE-TechWish.

[Please add project tags as project tags instead of subscribers - thanks a lot!]