Page MenuHomePhabricator
Create Task
Maniphest T292215

Validate Generic and User-Defined Types in JavaScript
Closed, ResolvedPublic
Actions

Description

Use schemata to validate atomic builtins; otherwise, implement this validation logic in JS.

Details

ProjectBranchLines +/-Subject
mediawiki/services/function-evaluatormaster+1 -1Update function-schemata sub-module to HEAD (502042c)
mediawiki/services/function-evaluatormaster+1 -1Update function-schemata sub-module to HEAD (4fade3b)
mediawiki/extensions/WikiLambdamaster+13 -7Update function-schemata sub-module to HEAD (502042c) and make pass
mediawiki/extensions/WikiLambdamaster+1 -1Update function-schemata sub-module to HEAD (4fade3b)
mediawiki/services/function-orchestratormaster+1 -1Update function-schemata sub-module to HEAD (6a1cb35)
mediawiki/services/function-schematamaster+423 -134Validate generic objects using a hybrid of JS and AJV validation.
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmassaro created this task.Sep 30 2021, 5:05 PM
cmassaro added a parent task: T292240: Save Un- (or Under-) Validated ZObjects, Validate Asynchronously via Orchestrator, Then Annotate ZObjects As Valid or Not.Sep 30 2021, 7:01 PM
cmassaro added a project: function-orchestrator.Sep 30 2021, 8:35 PM
DVrandecic assigned this task to cmassaro.Oct 6 2021, 4:19 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
gerritbot added a comment.Oct 6 2021, 4:27 PM

Change 726931 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Validate generic objects using a hybrid of JS and AJV validation.

https://gerrit.wikimedia.org/r/726931

gerritbot added a project: Patch-For-Review.Oct 6 2021, 4:27 PM
DVrandecic triaged this task as High priority.Oct 6 2021, 4:53 PM
gerritbot added a comment.Oct 7 2021, 5:43 PM

Change 726931 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Validate generic objects using a hybrid of JS and AJV validation.

https://gerrit.wikimedia.org/r/726931

cmassaro mentioned this in rMSFS6a1cb354a8fa: Validate generic objects using a hybrid of JS and AJV validation..Oct 7 2021, 5:43 PM
Jdforrester-WMF closed this task as Resolved.Oct 7 2021, 6:03 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 6:11 PM
gerritbot added a comment.Oct 7 2021, 6:14 PM

Change 727439 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (6a1cb35)

https://gerrit.wikimedia.org/r/727439

gerritbot added a project: Patch-For-Review.Oct 7 2021, 6:14 PM
gerritbot added a comment.Oct 7 2021, 6:41 PM

Change 727439 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (6a1cb35)

https://gerrit.wikimedia.org/r/727439

cmassaro mentioned this in rMSFO183ee7848905: Update function-schemata sub-module to HEAD (6a1cb35).Oct 7 2021, 6:41 PM
gerritbot added a comment.Oct 7 2021, 7:02 PM

Change 727465 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727465

gerritbot added a comment.Oct 7 2021, 7:03 PM

Change 727467 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727467

gerritbot added a comment.Oct 12 2021, 3:14 PM

Change 728456 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (502042c) and make pass

https://gerrit.wikimedia.org/r/728456

gerritbot added a comment.Oct 12 2021, 3:15 PM

Change 727467 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4fade3b)

Reason:

Squashed into Geno's patch.

https://gerrit.wikimedia.org/r/727467

gerritbot added a comment.Oct 12 2021, 5:44 PM

Change 728456 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (502042c) and make pass

https://gerrit.wikimedia.org/r/728456

gerritbot added a comment.Oct 12 2021, 6:12 PM

Change 727465 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fade3b)

https://gerrit.wikimedia.org/r/727465

Jdforrester-WMF mentioned this in rMSFEae3d9e0574a5: Update function-schemata sub-module to HEAD (4fade3b).Oct 12 2021, 6:13 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 12 2021, 7:10 PM
gerritbot added a comment.Oct 14 2021, 1:21 AM

Change 730668 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (502042c)

https://gerrit.wikimedia.org/r/730668

gerritbot added a project: Patch-For-Review.Oct 14 2021, 1:21 AM
gerritbot added a comment.Oct 18 2021, 4:06 PM

Change 730668 abandoned by Cory Massaro:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (502042c)

Reason:

https://gerrit.wikimedia.org/r/730668

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL