Page MenuHomePhabricator
Create Task
Maniphest T292224

Mentee overview: Truncate long usernames to 20 characters
Closed, ResolvedPublic
Actions

Assigned To
Urbanecm_WMF
Authored By
Urbanecm_WMF
Sep 30 2021, 6:25 PM
Tags
Referenced Files
F35009409: Screen Shot 2022-03-16 at 5.51.46 PM.png
Mar 17 2022, 12:52 AM
F35006090: Screen Shot 2022-03-14 at 7.25.52 PM.png
Mar 15 2022, 2:26 AM
F34687811: Screen Shot 2021-10-13 at 5.47.56 PM.png
Oct 14 2021, 12:57 AM
F34687814: Screen Shot 2021-10-13 at 5.48.09 PM.png
Oct 14 2021, 12:57 AM
F34687818: Screen Shot 2021-10-13 at 5.53.42 PM.png
Oct 14 2021, 12:57 AM
Subscribers
Aklapper
Etonkovidova
kostajh
Urbanecm_WMF

Description

Usernames should be truncated to 20 characters, to not let extremely long usernames break the table.

Details

SubjectRepoBranchLines +/-
Mentee overview: Truncate long usernames to 20 charactersmediawiki/extensions/GrowthExperimentsmaster+13 -0
Mentee overview: Update CSS selector to match realitymediawiki/extensions/GrowthExperimentsmaster+1 -1
Revert "Mentee overview: Truncate long usernames"mediawiki/extensions/GrowthExperimentswmf/1.38.0-wmf.3+0 -8
Revert "Mentee overview: Truncate long usernames"mediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.3+660 -0
Revert "Mentee overview: Truncate long usernames"mediawiki/extensions/GrowthExperimentsmaster+0 -8
Mentee overview: Truncate long usernamesmediawiki/extensions/GrowthExperimentsmaster+8 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm_WMF created this task.Sep 30 2021, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2021, 6:25 PM
Urbanecm_WMF claimed this task.Sep 30 2021, 6:28 PM
Urbanecm_WMF triaged this task as Medium priority.
Urbanecm_WMF added a project: User-Urbanecm_WMF (Engineering).
Urbanecm_WMF renamed this task from Mentee overview: Truncate long usernames to 20 characters to Mentee overview: Truncate long usernames to 15 characters.Sep 30 2021, 6:31 PM
Urbanecm_WMF updated the task description. (Show Details)
Urbanecm_WMF added a parent task: T278971: Mentor dashboard: M1 mentee overview module .
gerritbot added a comment.Sep 30 2021, 6:47 PM

Change 725086 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Truncate long usernames

https://gerrit.wikimedia.org/r/725086

gerritbot added a project: Patch-For-Review.Sep 30 2021, 6:47 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 30 2021, 6:48 PM
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Sep 30 2021, 7:35 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 30 2021, 7:57 PM
gerritbot added a comment.Sep 30 2021, 8:16 PM

Change 725086 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Truncate long usernames

https://gerrit.wikimedia.org/r/725086

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2021, 9:11 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 1 2021, 5:21 PM
kostajh mentioned this in T292660: Mentor dashboard is not displaying usernames properly (shortened or linewrapped).Oct 6 2021, 6:41 PM
gerritbot added a comment.Oct 8 2021, 7:02 AM

Change 727500 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Revert \"Mentee overview: Truncate long usernames\"

https://gerrit.wikimedia.org/r/727500

gerritbot added a project: Patch-For-Review.Oct 8 2021, 7:02 AM
Urbanecm_WMF moved this task from QA to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 8 2021, 7:03 AM
gerritbot added a comment.Oct 8 2021, 7:21 AM

Change 727500 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Revert \"Mentee overview: Truncate long usernames\"

https://gerrit.wikimedia.org/r/727500

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 8 2021, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 8 2021, 8:10 AM
gerritbot added a comment.Oct 8 2021, 8:17 AM

Change 727501 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Revert \"Mentee overview: Truncate long usernames\"

https://gerrit.wikimedia.org/r/727501

gerritbot added a project: Patch-For-Review.Oct 8 2021, 8:17 AM
gerritbot added a comment.Oct 8 2021, 8:24 AM

Change 728247 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Revert \"Mentee overview: Truncate long usernames\"

https://gerrit.wikimedia.org/r/728247

gerritbot added a comment.Oct 8 2021, 8:24 AM

Change 727501 abandoned by Urbanecm:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.3] Revert \"Mentee overview: Truncate long usernames\"

Reason:

wrong branch

https://gerrit.wikimedia.org/r/727501

Etonkovidova mentioned this in T292223: Mentee overview: Clicking on the user avatar sorts the table alphabetically instead of by activity.Oct 8 2021, 4:20 PM
gerritbot added a comment.Oct 12 2021, 7:54 AM

Change 728247 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Revert \"Mentee overview: Truncate long usernames\"

https://gerrit.wikimedia.org/r/728247

Stashbot mentioned this in T290609: Make mentee overview module's updateMenteeData.php scale better.Oct 12 2021, 7:58 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-12T07:58:08Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/GrowthExperiments/: 17dc3aa, e0ca905, c0f4f4e: GrowthExperiments backports (T292224, T290609, T290609) (duration: 00m 59s)

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2021, 8:10 AM
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 12 2021, 3:00 PM
Urbanecm_WMF moved this task from In review to Backlog on the User-Urbanecm_WMF (Engineering) board.Oct 13 2021, 7:36 PM
Etonkovidova subscribed.Oct 14 2021, 12:57 AM

Checked in wmf.4 and betalabs (the screenshots below are from betalabs):

Screen Shot 2021-10-13 at 5.47.56 PM.png (1×1 px, 170 KB)
for long user names (up to 44 characters)
Screen Shot 2021-10-13 at 5.48.09 PM.png (1×1 px, 151 KB)

@Urbanecm_WMF - the long usernames do not seem to be truncated to 15 characters. For example, User-0.8666571529808691-Iñtërnâtiônàlizætiøn should be User-0.86665715...

Screen Shot 2021-10-13 at 5.53.42 PM.png (866×1 px, 106 KB)

gerritbot added a comment.Oct 30 2021, 9:04 PM

Change 735722 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Update CSS selector to match reality

https://gerrit.wikimedia.org/r/735722

gerritbot added a project: Patch-For-Review.Oct 30 2021, 9:04 PM
gerritbot added a comment.Nov 1 2021, 4:32 PM

Change 735722 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Update CSS selector to match reality

https://gerrit.wikimedia.org/r/735722

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.7; 2021-11-02); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Nov 1 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 1 2021, 5:10 PM
kostajh moved this task from Ready for Development to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 10 2022, 2:24 PM
kostajh subscribed.
In T292224#7469905, @gerritbot wrote:

Change 735722 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Update CSS selector to match reality

https://gerrit.wikimedia.org/r/735722

@Etonkovidova I think this is done, after the above patch was merged. Could you please verify?

Urbanecm_WMF renamed this task from Mentee overview: Truncate long usernames to 15 characters to Mentee overview: Truncate long usernames to 20 characters.Mar 10 2022, 2:46 PM
Urbanecm_WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 10 2022, 2:46 PM

Change 769709 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Truncate long usernames to 20 characters

https://gerrit.wikimedia.org/r/769709

gerritbot added a project: Patch-For-Review.Mar 10 2022, 2:46 PM
Urbanecm_WMF moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 10 2022, 2:47 PM

Thanks for the reminder @kostajh. It was merged, but it was reverted later, and I forgot to upload a new patch. Another approach uploaded -- review would be appreciated.

Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Mar 10 2022, 2:47 PM
Urbanecm_WMF moved this task from My Part Done to In review on the User-Urbanecm_WMF (Engineering) board.Mar 13 2022, 2:05 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 14 2022, 9:14 AM
gerritbot added a comment.Mar 14 2022, 9:35 AM

Change 769709 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Mentee overview: Truncate long usernames to 20 characters

https://gerrit.wikimedia.org/r/769709

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.26; 2022-03-14); removed MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Mar 14 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 14 2022, 10:11 AM
MMiller_WMF added a project: GrowthExperiments-Mentorship.Mar 15 2022, 12:48 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 15 2022, 2:26 AM

Checked in betalabs - works as expected:

Screen Shot 2022-03-14 at 7.25.52 PM.png (1×1 px, 222 KB)

Etonkovidova closed this task as Resolved.Mar 17 2022, 12:52 AM

testwiki wmf.26

Screen Shot 2022-03-16 at 5.51.46 PM.png (1×1 px, 218 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL