Page MenuHomePhabricator
Create Task
Maniphest T292241

Subscription link in Minerva desktop displaying as one column
Closed, ResolvedPublic
Actions

Description

Capture.PNG (634×1 px, 24 KB)

https://ru.wikipedia.org/wiki/Википедия:Форум/Новости?useskin=minerva&uselang=en
In the Minerva skin, the "subscribe" link ( https://www.mediawiki.org/wiki/Help:DiscussionTools#Topic_subscriptions ) does not fit into the header

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix layout of [subscribe] links on desktop Minervamediawiki/extensions/DiscussionToolsmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sunpriat2 created this task.Sep 30 2021, 7:09 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 30 2021, 7:09 PM
Sunpriat2 added a parent task: T2738: Ability to watch section levels of pages.Sep 30 2021, 7:10 PM
Sunpriat2 removed a parent task: T2738: Ability to watch section levels of pages.Oct 1 2021, 12:50 AM
Sunpriat2 added projects: DiscussionTools, OWC2020.
ppelberg added a parent task: T280821: [Release Ticket] Introduce topic subscriptions on mobile.Oct 21 2021, 3:18 PM
ppelberg subscribed.

Thank you for reporting this, @Sunpriat2 – we're going to revisit this issue in the coming months when we focus on introducing DiscussionTools (of which Topic Subscriptions are one) on mobile.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Oct 21 2021, 3:18 PM
gerritbot added a comment.Nov 5 2021, 12:18 AM

Change 736930 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix layout of [subscribe] links on desktop Minerva

https://gerrit.wikimedia.org/r/736930

gerritbot added a project: Patch-For-Review.Nov 5 2021, 12:18 AM
• matmarex added a project: Editing-team (Kanban Board).Nov 5 2021, 12:18 AM
• matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
Esanders renamed this task from Subscription link in Minerva displaying as one column to Subscription link in Minerva desktop displaying as one column.Nov 5 2021, 11:23 PM
gerritbot added a comment.Nov 5 2021, 11:29 PM

Change 736930 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix layout of [subscribe] links on desktop Minerva

https://gerrit.wikimedia.org/r/736930

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 6 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 6 2021, 12:10 AM
• matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 8 2021, 12:15 AM
• matmarex added a project: Editing QA.
EAkinloose subscribed.Nov 17 2021, 1:47 PM

This looks good now

Screenshot 2021-11-17 at 14.41.44.png (820×2 px, 129 KB)

EAkinloose added a comment.Nov 17 2021, 6:03 PM

As an addition, "Unsubscribe" link works fine as well

Screenshot 2021-11-17 at 18.59.59.png (460×2 px, 77 KB)
.

QutieBot added a project: QTE-TestingOverview.Nov 17 2021, 6:07 PM
QutieBot moved this task from Inbox to Rummana on the QTE-TestingOverview board.
Ryasmeen edited projects, added Verified; removed QTE-TestingOverview, Editing QA.Nov 22 2021, 7:33 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Nov 29 2021, 5:50 PM
ppelberg claimed this task.
ppelberg mentioned this in T297448: [SPIKE] Review approach to improving mobile talk pages.Dec 23 2021, 1:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits