SecureLinkFixer updating bot is broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Sep 30 2021, 7:17 PM

Description

Seems to have broken like 8 weeks ago.

tools.slf@tools-sgebastion-08:~/SecureLinkFixer$ php maintenance/fetchList.php

Warning: file_get_contents(https://hg.mozilla.org/mozilla-central/atom-log/tip/security/manager/ssl/nsSTSPreloadList.inc): failed to open stream: HTTP request failed! in /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/includes/ListFetcher.php on line 59

Call Stack:
    0.0010     395504   1. {main}() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:0
    0.0088     415336   2. MediaWiki\SecureLinkFixer\main() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:45
    0.0089     415712   3. MediaWiki\SecureLinkFixer\ListFetcher->getLatestInfo() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:39
    0.0089     415712   4. file_get_contents() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/includes/ListFetcher.php:59


Fatal error: Uncaught RuntimeException: Unable to parse revision id/updated date for HSTS preload list in /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/includes/ListFetcher.php on line 63

RuntimeException: Unable to parse revision id/updated date for HSTS preload list in /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/includes/ListFetcher.php on line 63

Call Stack:
    0.0010     395504   1. {main}() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:0
    0.0088     415336   2. MediaWiki\SecureLinkFixer\main() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:45
    0.0089     415712   3. MediaWiki\SecureLinkFixer\ListFetcher->getLatestInfo() /mnt/nfs/labstore-secondary-tools-project/slf/SecureLinkFixer/maintenance/fetchList.php:39

If I run that file_get_contents locally, it works fine. Using curl from Toolforge also works fine.

Details

	Subject	Repo	Branch	Lines +/-
	Fetch list from GitHub	mediawiki/extensions/SecureLinkFixer	master	+32 -15

Customize query in gerrit

Related Objects

Mentioned In: rESLF2e20b3edcd90: Fetch list from GitHub

Event Timeline

Legoktm created this task.Sep 30 2021, 7:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2021, 7:17 PM

Probably easiest to just switch to grabbing https://github.com/mozilla/gecko-dev/blob/master/security/manager/ssl/nsSTSPreloadList.inc

Change 741726 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/SecureLinkFixer@master] WIP: Fetch list from GitHub

https://gerrit.wikimedia.org/r/741726

gerritbot added a project: Patch-For-Review.Nov 24 2021, 9:11 PM

Change 741726 merged by jenkins-bot:

[mediawiki/extensions/SecureLinkFixer@master] Fetch list from GitHub

https://gerrit.wikimedia.org/r/741726

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 24 2021, 10:00 PM

Legoktm mentioned this in rESLF2e20b3edcd90: Fetch list from GitHub.Nov 24 2021, 10:02 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 24 2021, 10:10 PM

I think I fixed it, we'll see next week.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecureLinkFixer/+/876331/

And by "fixed" I meant I ported fetchList.php to Rust and surprise surprise, it works perfectly. Source code is: https://gitlab.wikimedia.org/toolforge-repos/slf-bot/

SecureLinkFixer updating bot is brokenClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

SecureLinkFixer updating bot is broken
Closed, ResolvedPublic
Actions