We can merge the following:
Combine, always loaded together[1] * ext.flow.styles.base * ext.flow.board.styles * ext.flow.board.topic.styles Merge dependencies: ext.flow.ui * ext.flow.dm ext.flow * ext.flow.jquery.conditionalScroll * ext.flow.components ext.flow.components * ext.flow.jquery.findWithParent
Flow is a big and somewhat dated codebase, the Growth team doesn't have the capacity to take on Flow tech debt work unless it has a particularly high impact. (We'll do our best to review patches though.)
I can send patches for this, and since module data is sent on all page views on wikis where flow is installed, even if flow isn't used on that page, I think this would be high impact
Change 731132 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Merge style modules that are always loaded with ext.flow.styles.base
@Etonkovidova could you please have a look at Flow pages to ensure there's no style related breakage? (There shouldn't be :) )
Change 731132 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Merge style modules that are always loaded with ext.flow.styles.base
I monitored couple last two releases - no additional errors were thrown and the Flow functionality is in place.
Sorry, I haven't had a chance to keep working on this - I can add the current sprint tag back when there is another patch to review
Change 802624 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Merge ext.flow.dm into ext.flow.ui
Change 802625 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Merge ext.flow.jquery.findWithParent into ext.flow.components
Change 802826 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Merge dependencies into ext.flow
There's mentions of ext.flow.dm in the test files which look slightly off now.
https://codesearch.wmcloud.org/search/?q=ext.flow.dm%5Cb&i=nope&files=&excludeFiles=&repos=
QUnit.module( 'ext.flow.dm mw.flow.dm.Content' );
But, all the right info and keywords are stil there so not obvious what would be better other than perhaps to remove the bundle prefix. I'll leave that for Growth team to decide as they see fit.
Change 802624 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Merge ext.flow.dm into ext.flow.ui
This is still the case a few months after the above discussion, so I'm removing from the current sprint.
I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.