Merge single use TwoColConflict ResourceLoader modules to reduce module count
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	DannyS712
	Sep 30 2021, 8:12 PM

Description

Follow-up to T233280: Merge ResourceLoader modules that are never used independent from each other
The ext.TwoColConflict.SplitJs module has two dependencies, ext.TwoColConflict.Util and ext.TwoColConflict.Split.Tour, that are not used elsewhere and can just be merged into it

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Merge single use dependencies into ext.TwoColConflict.SplitJs	mediawiki/extensions/TwoColConflict	master	+43 -50
	Merge single use tour dependency into ext.TwoColConflict.SplitJs	mediawiki/extensions/TwoColConflict	master	+34 -45

Customize query in gerrit

Related Objects

Mentioned In: rESCC051ac712e9e8: Merge single use dependencies into ext.TwoColConflict.SplitJs
rESCC3a051399723f: Merge single use tour dependency into ext.TwoColConflict.SplitJs
Mentioned Here: T233280: Merge ResourceLoader modules that are never used independent from each other

Event Timeline

DannyS712 created this task.Sep 30 2021, 8:12 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 30 2021, 8:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Sep 30 2021, 8:12 PM

Change 731128 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/TwoColConflict@master] Merge single use dependencies into ext.TwoColConflict.SplitJs

https://gerrit.wikimedia.org/r/731128

gerritbot added a project: Patch-For-Review.Oct 15 2021, 8:28 PM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Oct 15 2021, 11:18 PM

Change 732615 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Merge single use tour dependency into ext.TwoColConflict.SplitJs

https://gerrit.wikimedia.org/r/732615

Change 732615 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Merge single use tour dependency into ext.TwoColConflict.SplitJs

https://gerrit.wikimedia.org/r/732615

DannyS712 mentioned this in rESCC3a051399723f: Merge single use tour dependency into ext.TwoColConflict.SplitJs.Oct 25 2021, 8:57 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 25 2021, 9:00 AM

thiemowmde added a project: WMDE-TechWish-Maintenance.Jan 19 2022, 11:55 AM

thiemowmde moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.Feb 25 2022, 3:08 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Change 731128 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Merge single use dependencies into ext.TwoColConflict.SplitJs

https://gerrit.wikimedia.org/r/731128

thiemowmde mentioned this in rESCC051ac712e9e8: Merge single use dependencies into ext.TwoColConflict.SplitJs.Jan 20 2024, 3:29 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2024, 3:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 20 2024, 5:00 PM

thiemowmde closed this task as Resolved.Feb 3 2024, 2:05 PM