Tests failing for the master branch of CentralNotice
Closed, ResolvedPublic
Actions

Description

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/724985, an empty patch with just a commit message
https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/139342/console

16:14:20 includes/BannerMessageGroup.php:206 PhanParamSignatureRealMismatchReturnType Declaration of function getMessageGroupStates() should be compatible with function getMessageGroupStates() : \MessageGroupStates (method where the return type in the real signature is '' cannot override method where the return type in the real signature is '\MessageGroupStates') defined in ../../extensions/Translate/messagegroups/MessageGroupOld.php:281

caused by rETRA29c1193419b2: Remove deprecated getWorkflowConfiguration in MediaWiki-extensions-Translate by @Nikerabbit

Outcome

Code change in Translate caused a build failure in CentralNotice. The troublesome code change in Translate was reverted to unblock CentralNotice development.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	MessageGroupBase: Remove typehint from getMessageGroupStates	mediawiki/extensions/Translate	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned Here: rETRA29c1193419b2: Remove deprecated getWorkflowConfiguration

Event Timeline

DannyS712 created this task.Sep 30 2021, 8:16 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptSep 30 2021, 8:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Sep 30 2021, 8:16 PM

Change 725190 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MessageGroupBase: Remove typehint from getMessageGroupStates

https://gerrit.wikimedia.org/r/725190

gerritbot added a project: Patch-For-Review.Oct 1 2021, 7:28 AM

abi_ changed the task status from Open to In Progress.Oct 1 2021, 7:46 AM

abi_ claimed this task.

abi_ triaged this task as High priority.

abi_ added a project: Language-Team (Language-2021-July-September).

abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.

Change 725190 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupBase: Remove typehint from getMessageGroupStates

https://gerrit.wikimedia.org/r/725190

Maintenance_bot removed a project: Patch-For-Review.Oct 1 2021, 9:10 AM

Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:32 PM

Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-October-December) board.

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 1 2021, 6:00 PM

Nikerabbit closed this task as Resolved.Oct 4 2021, 8:27 AM

Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2021-October-December) board.

Nikerabbit updated the task description. (Show Details)

Thanks much @DannyS712, @abi_, @Pginer-WMF, @Nikerabbit!!

Tests failing for the master branch of CentralNoticeClosed, ResolvedPublicActions