Page MenuHomePhabricator

Tests failing for the master branch of CentralNotice
Closed, ResolvedPublic

Description

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/724985, an empty patch with just a commit message
https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/139342/console

16:14:20 includes/BannerMessageGroup.php:206 PhanParamSignatureRealMismatchReturnType Declaration of function getMessageGroupStates() should be compatible with function getMessageGroupStates() : \MessageGroupStates (method where the return type in the real signature is '' cannot override method where the return type in the real signature is '\MessageGroupStates') defined in ../../extensions/Translate/messagegroups/MessageGroupOld.php:281

caused by rETRA29c1193419b2: Remove deprecated getWorkflowConfiguration in MediaWiki-extensions-Translate by @Nikerabbit

Outcome

Code change in Translate caused a build failure in CentralNotice. The troublesome code change in Translate was reverted to unblock CentralNotice development.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 725190 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] MessageGroupBase: Remove typehint from getMessageGroupStates

https://gerrit.wikimedia.org/r/725190

abi_ changed the task status from Open to In Progress.Oct 1 2021, 7:46 AM
abi_ claimed this task.
abi_ triaged this task as High priority.

Change 725190 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageGroupBase: Remove typehint from getMessageGroupStates

https://gerrit.wikimedia.org/r/725190

Nikerabbit updated the task description. (Show Details)