| MusikAnimal | |
| Sep 30 2021, 9:31 PM |
| F34751914: Screen Shot 2021-11-16 at 4.19.32 PM.png | |
| Nov 17 2021, 12:39 PM |
| F34744165: Screen Shot 2021-11-12 at 5.14.31 PM.png | |
| Nov 12 2021, 10:15 PM |
| F34663240: Screenshot from 2021-09-30 17-29-45.png | |
| Sep 30 2021, 9:31 PM |
This is an extension to T285508: Show notification when users type a link to a disambiguation page, which adds a feature that notifies the user after they type a link to a disambiguation page. This works only in the native MediaWiki editor. This task is about making it also work when MediaWiki-extensions-CodeMirror is enabled. Will live entirely in the Disambiguator.
Acceptance Criteria:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add CodeMirror compatibility to DisambiguatorNotifications | mediawiki/extensions/Disambiguator | master | +32 -17 |
Change 737998 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/Disambiguator@master] Add CodeMirror compatibility to DisambiguatorNotifications
Change 737998 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Add CodeMirror compatibility to DisambiguatorNotifications
For some reason source editing seems to be missing here: https://en.wikipedia.beta.wmflabs.org/wiki/Conflict-title-0.5849369982825903-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n?action=edit
I'm not able to test this now on beta 😒, will need to investigate whats up
The Code Mirror extension is in the 2010(?) wikitext editor. These instructions should tell you how to access it on beta: https://www.mediawiki.org/wiki/User:DWalden_(WMF)/Code_Mirror. Let me know if that helps.
I tested this a little bit on Friday. What I haven't tested so far is how the notification handles different ways of writing links in wikitext (see examples here: https://www.mediawiki.org/wiki/Help:Links)
Thanks @dom_walden that was helpful! My preference was set to show only one editor type. Will take a look at the different ways of writing links.
I have confirmed that disambiguation notification shows when highlighter is on and user types a disambiguation link
Note: Notification does not show when user inserts a disambiguation link
Test url: https://en.wikipedia.beta.wmflabs.org/wiki/BeforeEach-name-0.5880059578787176-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n
Note: The notification does not show on IE 11 browser only. It shows on other supported browsers.
Screen shot:
