In the AHT Engineering meeting 30th September 2021, we discussed pulling as many test cases as possible into the test harness for MediaWiki\Extensions\SecurePoll\Talliers\STVTallier in order to increase confidence before merging changes.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Convert existing fixtures to JSON | mediawiki/extensions/SecurePoll | master | +26 K -26 K | |
| Add additional STV test cases | mediawiki/extensions/SecurePoll | master | +842 K -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T289185 Use bc in STV algorithm | |||
| In Progress | Amdrel | T292295 Increase number of test cases covering STVTallier |
In the past, AHT stepped in to support Trust & Safety with the time-sensitive matter of the Board Elections by providing help with SecurePoll. Unfortunately, at this time we can no longer support nor maintain SecurePoll. Per the Foundation leadership’s instructions, AHT is dedicating all of our time and energy to other critical efforts.
Change #1115499 had a related patch set uploaded (by Amdrel; author: Amdrel):
[mediawiki/extensions/SecurePoll@master] Add additional STV test cases
Change #1115979 had a related patch set uploaded (by Amdrel; author: Amdrel):
[mediawiki/extensions/SecurePoll@master] Convert existing fixtures to JSON
Change #1115979 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert existing fixtures to JSON
Change #1115499 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Add additional STV test cases
I see a bunch of these tests were added already. I assume the ones added were the tests at https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results that are passing.
There are 27 failing tests on the page https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results . To get these added to SecurePoll, we'd probably need algorithm changes to the STV tallier.
Might need to add bug fixing to the acceptance criteria.