Page MenuHomePhabricator

[L] Image suggestions notifications UI
Closed, ResolvedPublic

Assigned To
Authored By
CBogen
Oct 1 2021, 6:51 PM
Referenced Files
F34948646: Desktop_without_thumbnail.png
Feb 11 2022, 4:46 PM
F34948645: Mobile_without_thumbnail.png
Feb 11 2022, 4:46 PM
F34946685: Mobile.png
Feb 9 2022, 2:45 PM
F34946686: Desktop.png
Feb 9 2022, 2:45 PM
F34939546: Image recommendation alert.png
Feb 1 2022, 3:04 PM
F34938659: Image recommendation alert.png
Jan 31 2022, 10:40 PM
F34706943: image.png
Oct 22 2021, 2:04 PM
F34705072: Image Suggestion Notification.png
Oct 21 2021, 7:38 PM

Description

This ticket is to create the UI for the new image suggestions notifications in Echo. We need a new Echo notification type so that we can suggest images for unillustrated articles to experienced users.

See here for how to create a new notification type https://www.mediawiki.org/wiki/Extension:Echo/Creating_a_new_notification_type

The code should live in a new extension, see T299924

Acceptance Criteria:

  • The notification is classified in Echo as a notice, not an alert
  • The notification contains the name of the unillustrated article that the image is matched to
  • The notification reads "We found media that might be a good fit for the article, {Article Name}, on your watchlist."
  • If the user clicks in the general notification space, they are taken to the file page of the suggested file on Commons
  • If the user clicks on Review media in the notification, they are taken to the file page of the suggested file on Commons
  • If the user clicks on Review article in the notification, they are taken to the article page for the recommended unillustrated article
  • Note: Having specific copy for specific media type is a nice to have and a preferred option if it is possible to include it. i.e. instead of using generic term "media", we can say image, video, audio, file etc. If this is difficult, we should break it into another task and save it in the backlog for V2. Now covered in T312130
  • If the user clicks on the "Help" link, they are taken to the help page for adding images on the language wiki with the recommendation
  • The "All notifications" link takes the user to Special:Notifications and the "Preferences" link takes the user to notification preferences (following the standard notification design.)
  • This ticket does *not* include the addition of a thumbnail, which is covered in T301354. Instead it should just show a generic icon as shown in the mock.
  • Design matches the following mocks
    Desktop_without_thumbnail.png (405×588 px, 24 KB)

Mobile_without_thumbnail.png (445×435 px, 23 KB)

Event Timeline

Note that the "we found image(s)" text will need to be revised to read something like "we found media" to account for video and audio suggestions. Final wording TBD.

CBogen updated the task description. (Show Details)
CBogen renamed this task from Image suggestions notifications UI to [L] Image suggestions notifications UI.Feb 9 2022, 5:32 PM
Seddon changed the task status from Open to In Progress.Feb 22 2022, 11:21 PM

Do we want to bundle notifications?

Do we want to bundle notifications?

@SWakiyama , @Sneha and I discussed this previously on Slack and determined that since there is a max of two notifications per week per user, we do not need to bundle. (Shari and Sneha, please let me know if you recall differently).

That might in and of itself be a good guide for a useful limit on the bundling of more than 8.

Change 769609 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/ImageSuggestions@main] WIP Image suggestions notifications UI

https://gerrit.wikimedia.org/r/769609

Change 778212 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@main] WIP Image suggestions notifications UI

https://gerrit.wikimedia.org/r/778212

Change 778212 abandoned by Matthias Mullie:

[mediawiki/extensions/ImageSuggestions@main] WIP Image suggestions notifications UI

Reason:

Nope

https://gerrit.wikimedia.org/r/778212

Change 778215 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ImageSuggestions@master] WIP Image suggestions notifications UI

https://gerrit.wikimedia.org/r/778215

Change 769609 abandoned by Matthias Mullie:

[mediawiki/extensions/ImageSuggestions@main] WIP Image suggestions notifications UI

Reason:

Resubmitted to "master" branch here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ImageSuggestions/+/778215

https://gerrit.wikimedia.org/r/769609

Change 766615 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[operations/mediawiki-config@master] Add ImageSuggestions to extension-list and config var

https://gerrit.wikimedia.org/r/766615

Change 766615 abandoned by Matthias Mullie:

[operations/mediawiki-config@master] Add ImageSuggestions to extension-list and config var

Reason:

Not yet!

https://gerrit.wikimedia.org/r/766615

Change 778215 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Image suggestions notifications UI

https://gerrit.wikimedia.org/r/778215

matthiasmullie subscribed.

Moving to blocked until the code has been deployed.

Change 766615 restored by Matthias Mullie:

[operations/mediawiki-config@master] Add ImageSuggestions to extension-list and config var

https://gerrit.wikimedia.org/r/766615

Change 766615 merged by jenkins-bot:

[operations/mediawiki-config@master] Add ImageSuggestions to extension-list and config var

https://gerrit.wikimedia.org/r/766615