Page MenuHomePhabricator

Upgrade all deployment charts to use the latest version of common_templates
Closed, ResolvedPublic

Description

We need, for every chart in our repository that makes use of common_templates (all of them minus eventgate AIUI):

  • Link the common templates in version 0.4
  • check if deployment.yaml includes routed_via
  • Bump the chart number
  • Deploy to staging, then codfw, then eqiad, verifying everything works.

Event Timeline

Joe triaged this task as Medium priority.Oct 4 2021, 7:37 AM
Joe created this task.
Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptOct 4 2021, 7:37 AM

You think we can piggyback the necessary helmfile.yaml changes for the helm3 migration (T251305) with this @Jelto ?

Should be possible and sounds like a good idea to piggyback this with T251305 if we are going to re-deploy all services anyway.

Change 734926 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/deployment-charts@master] blubberoid: bump common_templates to 0.4 and chart version

https://gerrit.wikimedia.org/r/734926

Change 734926 merged by Jelto:

[operations/deployment-charts@master] blubberoid: bump common_templates to 0.4 and chart version

https://gerrit.wikimedia.org/r/734926

Change 736227 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/deployment-charts@master] charts: bump common_templates to 0.4 and chart versions

https://gerrit.wikimedia.org/r/736227

Change 736227 merged by jenkins-bot:

[operations/deployment-charts@master] charts: bump common_templates to 0.4 and chart versions

https://gerrit.wikimedia.org/r/736227

Change 736532 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/deployment-charts@master] charts:chromium-reader fix wrong labels and selectors in deployment

https://gerrit.wikimedia.org/r/736532

Change 736532 merged by jenkins-bot:

[operations/deployment-charts@master] charts:chromium-reader fix wrong labels and selectors in deployment

https://gerrit.wikimedia.org/r/736532

Change 736540 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/deployment-charts@master] charts:chromium-reader bump chart version

https://gerrit.wikimedia.org/r/736540

Change 736540 merged by jenkins-bot:

[operations/deployment-charts@master] charts:chromium-reader bump chart version

https://gerrit.wikimedia.org/r/736540

Jelto added subscribers: elukey, Ottomata.

Most deployment charts were updated in 736227. The services were re-deployed with common_templates 0.4 in staging. codfw and eqiad re-deploy is blocked by helm3 migration (T251305) but should happen the week after next (due to my clinic duty).

However some services are still using old common_templates:

  • eventstreams (0.2)
  • eventgate (0.2)
  • knative-serving (0.3)
  • kserve-inference (0.3)

@Ottomata and @elukey are you the right folks to tag here? Do you plan to upgrade to a newer common_templates version in your charts soon? And do you need any support for the migration?

Hiya!

Yes, I would love to upgrade. I tried to do this once but got confused and filed T291848: Clarify common k8s label and service conventions in our helm charts. Joe answered many of my questions, but there are still a few there..and then @JMeybohm mentioned T253395: Change helm chart default labels to k8s standard.

Perhaps we should wait until a new common_templates does T253395?

Change 738578 had a related patch set uploaded (by Jelto; author: Jelto):

[operations/deployment-charts@master] charts:eventgate bump common_templates and standardize labels

https://gerrit.wikimedia.org/r/738578

Change 755638 had a related patch set uploaded (by Elukey; author: Elukey):

[operations/deployment-charts@master] knative-serving,kserve-inference: move _helpers.tpl to 0.4

https://gerrit.wikimedia.org/r/755638

Change 755638 merged by Elukey:

[operations/deployment-charts@master] knative-serving,kserve-inference: move _helpers.tpl to 0.4

https://gerrit.wikimedia.org/r/755638

knative-serving and kserve-inference should be done! :)

BTW, I made a specific task to track the work to make eventgate chart use common_templates: T303543: eventgate chart should use common_templates cc @BTullis

Change 831957 had a related patch set uploaded (by Gmodena; author: Gmodena):

[operations/deployment-charts@master] charts:eventstreams bump common_templates and standardize labels

https://gerrit.wikimedia.org/r/831957

Change 831957 merged by jenkins-bot:

[operations/deployment-charts@master] charts:eventstreams bump common_templates and standardize labels

https://gerrit.wikimedia.org/r/831957

Change 833447 had a related patch set uploaded (by Gmodena; author: Gmodena):

[operations/deployment-charts@master] Bump eventstreams chart version.

https://gerrit.wikimedia.org/r/833447

Change 833447 merged by jenkins-bot:

[operations/deployment-charts@master] Bump eventstreams chart version.

https://gerrit.wikimedia.org/r/833447

Change 738578 merged by jenkins-bot:

[operations/deployment-charts@master] charts:eventgate bump common_templates and standardize labels

https://gerrit.wikimedia.org/r/738578

We've since moved to using modules.