List of steps to reproduce (step by step, including full links if applicable):
- Go to Special:MediaSearch on Commons and set debug=true in the URL params
- Open the browser console and check for errors
What happens?:
Every <SdSelect> component (the dropdown menus in the filter bar) will complain about invalid props:
[Vue warn]: Invalid prop: type check failed for prop "label". Expected String with value "Community Assessments", got Object
found in
---> <SdSelect>
<SearchFilters>
<SdTab>
<SdTabs>
<MediaSearch>
<Root>Functionality is not impacted.
What should have happened instead?:
This component should be receiving props which match the expected values.
This change is a consequence of the patch that fixed T285349. We are now passing in a label value (we weren't doing this before) as part of the behavior change specified in that patch.
The component expects Strings; we are passing in Message objects that resolve to strings. The fact that the object's toString behavior provides what we want is why this error has no user-facing impact. It should still be fixed ASAP.