Page MenuHomePhabricator

Context of Visual differences become invisible under mobile view
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Turm to any wiki with Visual differences feature and mobile view.
  • Checkout any diff under mobile view.

What happens?:
Paragraphs before and after the difference become invisible but take exact space, because these elements have z-index: -1; style.
(All elements with negative z-index would be invisible under mobile view)

What should have happened instead?:
These paragraphs show up normally.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
All Wikimedia wikis, newest chrome

Event Timeline

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex subscribed.

This might be a recent regression, I think this worked fine in the past (T244673#5874183).

The negative z-index was introduced in 2018 (T190916), but the link above appears to show it working in 2020.

Testing on 1.36 it is broken, and on 1.35 the visual diff is not available on mobile. It works in both of those releases with desktop minerva, so the conflict is with MobileFrontend styles.

Change 730844 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Create new stacking context for diffElement

https://gerrit.wikimedia.org/r/730844

Change 730844 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Create new stacking context for diffElement

https://gerrit.wikimedia.org/r/730844

Change 730881 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4373b0a6e)

https://gerrit.wikimedia.org/r/730881

Change 730881 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4373b0a6e)

https://gerrit.wikimedia.org/r/730881