Page MenuHomePhabricator

Task and topic filters not preserved in onboarding
Open, MediumPublicBUG REPORT

Description

We are not properly preserving the state of task and topic filters during the onboarding experience.

Step 1:

image.png (1×958 px, 540 KB)

Step 2:

image.png (1×958 px, 523 KB)

Step 3:

image.png (1×958 px, 846 KB)

So far so good. Now, I open the topic filter:

image.png (1×958 px, 589 KB)

My topic is not listed, and if I press "Done" the filter is unset.

image.png (1×958 px, 834 KB)

Same issue with the task type filter, my selection of "Copyedit" has disappeared:

image.png (1×958 px, 517 KB)

Note that if you make a topic and task type selection during onboarding, and *do not* interact with the topic/task filters, and then visit Special:Homepage
again, the selection you made in onboarding is preserved. So there is probably a relatively quick fix to be made when the dialog is opened during onboarding to check if initial settings exist, and if so, to respect those instead of overwriting them.

Event Timeline

kostajh triaged this task as Medium priority.Tue, Oct 5, 2:11 PM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh changed the subtype of this task from "Task" to "Bug Report".EditedTue, Oct 5, 2:12 PM
kostajh added subscribers: DMburugu, MMiller_WMF.

@MMiller_WMF @DMburugu I'm putting this in the current sprint, as this bug impacts any user who sets task/topic filters during onboarding and then wants to inspect them during their initial view of Special:Homepage.

Change 727451 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/727451

When the topic/difficulty selection is updated via growthexperiments.StartEditingDialog.updateMatchCount hook, the local copy of the presets isn't updated so when the dialogs are re-opened during the same session, the selection states are out of sync. When the session re-starts (ie. visit Special:Homepage again), the local copy of the presets has the saved values.

With fix:

se_filters_onboarding.gif (1×1 px, 3 MB)

Change 727451 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/727451

Change 730371 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/730371

Change 730371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/730371

Mentioned in SAL (#wikimedia-operations) [2021-10-13T12:10:59Z] <kharlan@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/GrowthExperiments/modules: Backport: [[gerrit:730371|Suggested Edits: Update local config.presets when topics/difficulty presets change (T292536)]] (duration: 01m 07s)

There's still one more bug to solve here, sorry I missed this in code review.

In my local wiki, I select Biography (39 articles)

image.png (1×1 px, 200 KB)

image.png (1×1 px, 186 KB)

I check the box for "Copyedit", I see 40 articles found

image.png (1×1 px, 186 KB)

I press "Get suggestions"

I tap the topic filter, and the count is correct:

image.png (1×1 px, 332 KB)

I tap the task type filter, and the count is 19 articles. (Yes the screenshot here shows "References" also -- the error is not exactly deterministic as far as I can tell, and I also saw the miscount once while opening the topic filters, though it seems to mostly happen with the task type filters.)

image.png (1×1 px, 244 KB)

Hi @kostajh — is the miscount issue unique to when the filters are selected during onboarding or does this also occur when they are selected from the suggested edits module? To me, this sounds like it's a separate issue than the initially reported one but I wanted to make sure.

One possible reason is that we make multiple searches internally (one for each tasktype+topic combo) and then just sum up the result counts, but articles can belong to multiple topics and task types. That was discussed somewhat in T260522: Optimize number of results requested from API. I don't think that can be really fixed, but I think I had some improvements somewhere deep in git stash, will try to find them.

Hi @kostajh — is the miscount issue unique to when the filters are selected during onboarding or does this also occur when they are selected from the suggested edits module? To me, this sounds like it's a separate issue than the initially reported one but I wanted to make sure.

The miscount only happens in the initial, freshly-onboarded state. After a page reload, I can't make the issue re-appear. Arguably it is a separate issue, but it sounds related enough.

kostajh moved this task from QA to Ready for Development on the Growth-Team (Current Sprint) board.

Oops, didn't mean to move this to QA yet.