@MMiller_WMF @DMburugu I'm putting this in the current sprint, as this bug impacts any user who sets task/topic filters during onboarding and then wants to inspect them during their initial view of Special:Homepage.

Change 727451 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/727451

When the topic/difficulty selection is updated via growthexperiments.StartEditingDialog.updateMatchCount hook, the local copy of the presets isn't updated so when the dialogs are re-opened during the same session, the selection states are out of sync. When the session re-starts (ie. visit Special:Homepage again), the local copy of the presets has the saved values.

With fix:

Change 727451 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/727451

Change 730371 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/730371

Change 730371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.3] Suggested Edits: Update local config.presets when topics/difficulty presets change

https://gerrit.wikimedia.org/r/730371

Mentioned in SAL (#wikimedia-operations) [2021-10-13T12:10:59Z] <kharlan@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/GrowthExperiments/modules: Backport: [[gerrit:730371|Suggested Edits: Update local config.presets when topics/difficulty presets change (T292536)]] (duration: 01m 07s)

There's still one more bug to solve here, sorry I missed this in code review.

In my local wiki, I select Biography (39 articles)

I check the box for "Copyedit", I see 40 articles found

I press "Get suggestions"

I tap the topic filter, and the count is correct:

I tap the task type filter, and the count is 19 articles. (Yes the screenshot here shows "References" also -- the error is not exactly deterministic as far as I can tell, and I also saw the miscount once while opening the topic filters, though it seems to mostly happen with the task type filters.)

Hi @kostajh — is the miscount issue unique to when the filters are selected during onboarding or does this also occur when they are selected from the suggested edits module? To me, this sounds like it's a separate issue than the initially reported one but I wanted to make sure.

One possible reason is that we make multiple searches internally (one for each tasktype+topic combo) and then just sum up the result counts, but articles can belong to multiple topics and task types. That was discussed somewhat in T260522: Optimize number of results requested from API. I don't think that can be really fixed, but I think I had some improvements somewhere deep in git stash, will try to find them.

In T292536#7425420, @mewoph wrote:

Hi @kostajh — is the miscount issue unique to when the filters are selected during onboarding or does this also occur when they are selected from the suggested edits module? To me, this sounds like it's a separate issue than the initially reported one but I wanted to make sure.

The miscount only happens in the initial, freshly-onboarded state. After a page reload, I can't make the issue re-appear. Arguably it is a separate issue, but it sounds related enough.

Oops, didn't mean to move this to QA yet.