Page MenuHomePhabricator

Drop the non-standard components folder
Closed, ResolvedPublic


Minerva lists templates inside a components folder. This is problematic as it means you need to create a separate TemplateParser to parse them. It also means template retrieval is not centralized to a central place, meaning if not careful a template could include a PHP file or JS file.

This folder should live inside includes/Skins with the other templates.

This will aid us in the removal of MinervaTemplate by allowing skin.mustache to access the template partials inside this folder.

Event Timeline

Change 726663 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove non-standard components folder

Change 726663 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove non-standard components folder