ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jeena
	Oct 5 2021, 7:12 PM

Description

Error

mwversion: 1.38.0-wmf.3
reqId: afa6439a-c7e4-4595-a27f-055195871e50
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Notice: Undefined offset: 1

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.3/includes/page/ImageHistoryPseudoPager.php(142)
#0 /srv/mediawiki/php-1.38.0-wmf.3/includes/page/ImageHistoryPseudoPager.php(142): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.3/includes/page/ImagePage.php(838): ImageHistoryPseudoPager->getBody()
#2 /srv/mediawiki/php-1.38.0-wmf.3/includes/page/ImagePage.php(183): ImagePage->imageHistory()
#3 /srv/mediawiki/php-1.38.0-wmf.3/includes/actions/ViewAction.php(74): ImagePage->view()
#4 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(538): ViewAction->show()
#5 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(320): MediaWiki->performAction(ImagePage, Title)
#6 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(925): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.38.0-wmf.3/includes/MediaWiki.php(559): MediaWiki->main()
#8 /srv/mediawiki/php-1.38.0-wmf.3/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.38.0-wmf.3/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Impact

A string of errors (~50 in a 10 minute window) occurred after deployment to group0, causing a rollback

Notes

Details

Request URL: https://www.mediawiki.org/wiki/File:Symbol_LED.svg

Project	Branch	Lines +/-	Subject
mediawiki/core	wmf/1.38.0-wmf.4	+11 -7	Pre-format comments for non-local files too
mediawiki/core	master	+11 -7	Pre-format comments for non-local files too
mediawiki/core	wmf/1.38.0-wmf.3	+11 -7	Pre-format comments for non-local files too

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281168 1.38.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	dancy	T292570 ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n]

Event Timeline

jeena created this task.Oct 5 2021, 7:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2021, 7:12 PM

jeena added a parent task: T281167: 1.38.0-wmf.3 deployment blockers.Oct 5 2021, 7:13 PM

cc @tstarling

Zabe moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Oct 5 2021, 7:18 PM

Zabe moved this task from Sep 2021 to Untriaged on the Wikimedia-production-error board.

Wondering if T285917 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/708241 are relevant here - cc: @tstarling.

brennen renamed this task from PHP Notice: Undefined offset: 1 to ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n].Oct 5 2021, 7:30 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Ok, this is clearly a fallout from CommentFormatter.

The loop that formats the comments is skipped for non-local files, while the loop that's showing the comments is not skipped. Boom.

Change 726680 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/726680

gerritbot added a project: Patch-For-Review.Oct 5 2021, 7:39 PM

^ should take care of this. Didn't test locally cause it's really, really hard to test locally.

should take care of this. Didn't test locally cause it's really, really hard to test locally.

We can probably test this cleanly on an mwdebug, right?

yup. a page view request to any non-local file will be a sufficient test. the URL from task description for example

Change 726594 had a related patch set uploaded (by Brennen Bearnes; author: Ppchelko):

[mediawiki/core@wmf/1.38.0-wmf.3] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/726594

Change 726594 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.3] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/726594

Mentioned in SAL (#wikimedia-operations) [2021-10-05T20:44:48Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.3/includes/page: Backport: [[gerrit:726594|Pre-format comments for non-local files too]] (T292570) (duration: 01m 04s)

Looks fixed in production, removing as a train blocker, leaving open in case there's feedback on the patch for master.

brennen removed a parent task: T281167: 1.38.0-wmf.3 deployment blockers.Oct 5 2021, 8:59 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 5 2021, 9:00 PM

brennen mentioned this in T292590: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentItem::__construct() must be of the type string, null given.Oct 5 2021, 9:54 PM

brennen moved this task from Untriaged to Oct 2021 on the Wikimedia-production-error board.Oct 6 2021, 6:52 PM

brennen mentioned this in T292797: CommentFormatter: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentParser::preprocess() must be of the type string, null given.Oct 7 2021, 10:28 PM

Since the patch has not been merged into master this is going to regress and the error is going to show up again in wmf.4.

Change 730226 had a related patch set uploaded (by Zabe; author: Ppchelko):

[mediawiki/core@wmf/1.38.0-wmf.4] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/730226

Change 726680 merged by jenkins-bot:

[mediawiki/core@master] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/726680

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.5; 2021-10-19); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 12 2021, 4:00 PM

Change 730226 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.4] Pre-format comments for non-local files too

https://gerrit.wikimedia.org/r/730226

Mentioned in SAL (#wikimedia-operations) [2021-10-12T16:26:28Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.4/includes: Backport: [[gerrit:730226|Pre-format comments for non-local files too (T292570)]] (duration: 01m 15s)

dancy closed this task as Resolved.Oct 12 2021, 4:29 PM

dancy claimed this task.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.4; 2021-10-12); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 12 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2021, 5:10 PM

ImageHistoryPseudoPager: PHP Notice: Undefined offset: [n]Closed, ResolvedPublicPRODUCTION ERRORActions