Page MenuHomePhabricator
Create Task
Maniphest T292582

Matching Gifts - Employer IDs showing in Field
Closed, ResolvedPublic
Actions

Description

hey fr-tech, hopefully quick question on Matching gifts UX:

I was just making a test donation and saw that when you arrow down through the employers, you see their ID in the Field, not their name. Then their name appears once you make a selection. Is this the intended behavior?

Just wanted to flag in case we didn't want that to be happening. I was using this variant.

Screen Shot 2021-10-05 at 14.25.51.png (474×838 px, 153 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix employer select arrow key navigationmediawiki/extensions/DonationInterfacemaster+11 -6
Customize query in gerrit

Event Timeline

HNordeenWMF created this task.Oct 5 2021, 8:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2021, 8:27 PM
HNordeenWMF updated the task description. (Show Details)Oct 5 2021, 8:28 PM
XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Oct 12 2021, 8:04 PM
XenoRyet moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Nov 23 2021, 9:17 PM
XenoRyet added a project: fundraising sprint Wireless Zipline.Nov 23 2021, 9:23 PM
Ejegg claimed this task.Nov 24 2021, 12:48 AM
Ejegg moved this task from Backlog to Doing on the fundraising sprint Wireless Zipline board.
gerritbot added a comment.Nov 24 2021, 1:34 AM

Change 740952 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Fix employer select arrow key navigation

https://gerrit.wikimedia.org/r/740952

gerritbot added a project: Patch-For-Review.Nov 24 2021, 1:34 AM
Ejegg moved this task from Doing to Review on the fundraising sprint Wireless Zipline board.Nov 24 2021, 1:35 AM
gerritbot added a comment.Nov 25 2021, 2:01 AM

Change 740952 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Fix employer select arrow key navigation

https://gerrit.wikimedia.org/r/740952

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2021, 2:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 25 2021, 3:00 AM
Ejegg moved this task from Review to Pending Deployment on the fundraising sprint Wireless Zipline board.Nov 25 2021, 3:27 AM
Ejegg moved this task from Pending Deployment to Done on the fundraising sprint Wireless Zipline board.Dec 1 2021, 10:35 PM
• DStrine triaged this task as Medium priority.Dec 3 2021, 5:22 PM
• DStrine closed this task as Resolved.Dec 7 2021, 8:09 PM
Ejegg set Final Story Points to 1.Dec 7 2021, 9:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits